Utilized min function for verbosity line 25 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull requests should contain useful information about the reasoning behind the changes for the repository maintainer to enable them to prioritize PRs. This is part of the collaborative workflow. |
|
The PR should have been made to the ensf400-ws24 branch, not to main. |
growlf
requested changes
Feb 25, 2024
There was a problem hiding this comment.
This change will actually remove useful code. Please look at the other service definitions in this file.
There was a problem hiding this comment.
This change is from an existing branch and is not needed here - once that branch is merged.
Comment on lines
-16
to
-18
| - ${HOME}/.gitconfig:/home/ubuntu/.gitconfig | ||
| - ${HOME}/.ssh:/home/ubuntu/.ssh | ||
| - ${PWD}:/app |
There was a problem hiding this comment.
This is for local credentials and allows development entirely within the safety of the container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.