Skip to content

Commit

Permalink
Updated readme and contributing
Browse files Browse the repository at this point in the history
  • Loading branch information
canemacchina committed Aug 14, 2017
1 parent 02bce01 commit 5fac0f8
Show file tree
Hide file tree
Showing 3 changed files with 69 additions and 6 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# CHANGELOG
53 changes: 53 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1 +1,54 @@
# Contributing

[code-of-conduct]: CODE_OF_CONDUCT.md

Hi there! We're thrilled that you'd like to contribute to this project. Your help is essential for keeping it great.

Please note that this project is released with a [Contributor Code of Conduct][code-of-conduct]. By participating in this project you agree to abide by its terms.

## Contribution Agreement

As a contributor, you represent that the code you submit is your original work or that of your employer (in which case you represent you have the right to bind your employer). By submitting code, you (and, if applicable, your employer) are licensing the submitted code to the open source community subject to the [GNU AGPL-3.0](LICENSE)

## Coding conventions

Please respect our code style.
We use a sligtly modified version of Google Java Style Guide. You can find useful files to configure your IDE or to chek your code through Checkstyle into the resources directory.

Also, please carefully follow the whitespace and formatting conventions already present:

- use spaces, not tabs;
- use Unix (LF), not DOS (CRLF) line endings;
- eliminate all trailing whitespace;
- preserve existing formatting; i.e. do not reformat code for its own sake;
- use UTF-8 encoding for sources files.

## Submitting changes

Please send a pull request with a clear list of what you've done. And don't forget to write test for your code: we usually like to improve our code coverage.

Please always write a clear log message for your commits. One-line messages are fine for small changes, but bigger changes should look like this:

$ git commit -m "A brief summary of the commit
>
> A paragraph describing what changed and its impact."

## Coding flow

When contributing to this repository, please first discuss the change you wish to make via issue before making a change. After that, you should:

1. [fork][fork] and clone the repository;
1. create a new branch naming it `XYZ-something` where `XYZ` is the number of the issue;
1. make your changes;
1. increase the version numbers into the pom.xml file. The versioning scheme we use is [SemVer](http://semver.org/);
1. update the [CHANGELOG](CHANGELOG.md) file with details of changes.
1. run the unit tests and make sure they pass;
1. push to your fork and submit a pull request. Please attach to the pr any useful informations needed for deploy process (as, for example, new properties to configure to production);
1. relax and wait for your pull request to be reviewed and merged.

Here are a few things you can do that will increase the likelihood of your pull request being accepted:

- keep your change as focused as possible. If there are multiple changes you would like to make that are not dependent upon each other, consider submitting them as separate pull requests;
- write a good commit message;
- in your pull request description, provide as much detail as possible. This context helps the reviewer to understand the motivation for and impact of the change;
- make sure that all the unit tests still pass. PRs with failing tests won't be merged.
21 changes: 15 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,22 @@
[![Issue Count](https://codeclimate.com/github/growingabit/pwa-backend/badges/issue_count.svg)](https://codeclimate.com/github/growingabit/pwa-backend)

## Contribution
Please respect our code style.
We use a sligtly modified version of Google Java Style Guide. You can find useful files to configure your ide or to make code analisys through checkstyle into the resources directory
Read the [CONTRIBUTING](CONTRIBUTING.md) file.

## useful maven commands:
## Changelog
[CHANGELOG](CHANGELOG.md).

## Run the application

`mvn appengine:run`

## Executing tests

`mvn test`

## Other useful maven commands:

- `mvn test` to run test (obv :D);
- `mvn cobertura:cobertura` to run coverage tool. You can see a coverage report navigating into `target/site/cobertura`;
- `mvn checkstyle:check` to perform a Checkstyle analysis and print violations to the console;
- `mvn versions:display-dependency-updates` to check for update of dependencies
- `mvn versions:display-plugin-updates` to check for update of plugins
- `mvn versions:display-dependency-updates` to check for update of dependencies;
- `mvn versions:display-plugin-updates` to check for update of plugins.

0 comments on commit 5fac0f8

Please sign in to comment.