-
Notifications
You must be signed in to change notification settings - Fork 235
Release v7.4.3 #10689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
github-actions
wants to merge
72
commits into
release/current
Choose a base branch
from
master
base: release/current
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release v7.4.3 #10689
+1,947
−3,632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… references and streamline tag outputs
…undary-types lines
…m-eslint-rest-files support: Migrate the rest of files to Biome from Eslint
…docker-image-to-weseek-repository support: Stop pushing docker image to weseek repository
- Add lefthook as dev dependency in root package.json - Create lefthook.yml with pre-commit hook for Biome formatting - Update .devcontainer/app/postCreateCommand.sh to install Lefthook hooks - Update .devcontainer/pdf-converter/postCreateCommand.sh to install Lefthook hooks - Configured to automatically format staged files with Biome on commit - Excludes Stylelint as per requirement (Stylelint not included in hooks) Co-authored-by: yuki-takei <[email protected]>
imprv: Admin Home
- Changed from npx to pnpm biome in lefthook.yml (project uses pnpm) - Added --unsafe flag to apply safe fixes as per Biome official docs - Configured pnpm to only build lefthook dependency (not other deps) Co-authored-by: yuki-takei <[email protected]>
Per Biome official documentation, --unsafe should NOT be used in pre-commit hooks. The --unsafe flag applies both safe AND unsafe fixes, which could break code logic. Pre-commit hooks should only apply safe fixes using --write without --unsafe. Co-authored-by: yuki-takei <[email protected]>
…utomation support: Integrate Lefthook for pre-commit Biome formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Improvement
🧰 Maintenance