Skip to content

feat: content disposition headers logic #10658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ryosei-Fukushima wants to merge 3 commits into
base: feat/158232-prevent-inline-mime-type-sniffing-vulnerabilities
Choose a base branch
from
Open

feat: content disposition headers logic #10658

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7858ee
fix content disposition header logic
Ryosei-Fukushima Dec 23, 2025
4c2c4e7
delete comment
Ryosei-Fukushima Dec 26, 2025
f9c5fc8
fix logic
Ryosei-Fukushima Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion apps/app/src/server/service/file-uploader/utils/headers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,35 @@ import type { Response } from 'express';
import type { ExpressHttpHeader } from '~/server/interfaces/attachment';
import type { IAttachmentDocument } from '~/server/models/attachment';

import { configManager } from '../../config-manager';

import { defaultContentDispositionSettings } from './security';

type ContentHeaderField = 'Content-Type' | 'Content-Security-Policy' | 'Content-Disposition' | 'Content-Length';
type ContentHeader = ExpressHttpHeader<ContentHeaderField>;

const determineDisposition = (
fileFormat: string,
opts?: { inline?: boolean },
): 'inline' | 'attachment' => {
const inlineMimeTypes = configManager.getConfig('attachments:contentDisposition:inlineMimeTypes').inlineMimeTypes;
const attachmentMimeTypes = configManager.getConfig('attachments:contentDisposition:attachmentMimeTypes').attachmentMimeTypes;

const normalizedFileFormat = fileFormat.toLowerCase();

if (attachmentMimeTypes.some(mimeType => mimeType.toLowerCase() === normalizedFileFormat)) {
return 'attachment';
}
if (inlineMimeTypes.some(mimeType => mimeType.toLowerCase() === normalizedFileFormat)) {
return 'inline';
}
const defaultSetting = defaultContentDispositionSettings[normalizedFileFormat];
if (defaultSetting) {
return defaultSetting;
}
return opts?.inline ? 'inline' : 'attachment';
};

/**
* Factory function to generate content headers.
* This approach avoids creating a class instance for each call, improving memory efficiency.
Expand All @@ -27,9 +53,10 @@ export const createContentHeaders = (attachment: IAttachmentDocument, opts?: { i
});

// Content-Disposition
const disposition = determineDisposition(attachment.fileFormat, opts);
headers.push({
field: 'Content-Disposition',
value: `${opts?.inline ? 'inline' : 'attachment'};filename*=UTF-8''${encodeURIComponent(attachment.originalName)}`,
value: `${disposition};filename*=UTF-8''${encodeURIComponent(attachment.originalName)}`,
});

// Content-Length
Expand Down