Skip to content

Commit

Permalink
Merge #229
Browse files Browse the repository at this point in the history
229: deprecate *_from_gl_name functions (native) r=grovesNL a=i509VCB

The constructors for the Native* types are public now and therefore these from_gl_name functions are redundant.

Co-authored-by: i509VCB <[email protected]>
  • Loading branch information
bors[bot] and i509VCB authored Sep 23, 2022
2 parents c8a011f + 92ec34b commit 7e702f6
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/native.rs
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ impl Context {
///
/// This can be useful when a texture is created outside of glow (e.g. OpenXR surface) but glow
/// still needs access to it for rendering.
#[deprecated = "Use the NativeTexture constructor instead"]
pub unsafe fn create_texture_from_gl_name(gl_name: native_gl::GLuint) -> NativeTexture {
NativeTexture(non_zero_gl_name(gl_name))
}
Expand All @@ -98,6 +99,7 @@ impl Context {
///
/// This can be useful when a framebuffer is created outside of glow (e.g: via `surfman` or another
/// crate that supports sharing of buffers between GL contexts), but glow needs to set it as a target.
#[deprecated = "Use the NativeFramebuffer constructor instead"]
pub unsafe fn create_framebuffer_from_gl_name(gl_name: native_gl::GLuint) -> NativeFramebuffer {
NativeFramebuffer(non_zero_gl_name(gl_name))
}
Expand Down

0 comments on commit 7e702f6

Please sign in to comment.