Skip to content

fix: consolidate unresolved review feedback from PRs #26, #6, #4, #13#41

Closed
Copilot wants to merge 3 commits intogroupthinking-patch-2from
copilot/review-pending-prs-another-one
Closed

fix: consolidate unresolved review feedback from PRs #26, #6, #4, #13#41
Copilot wants to merge 3 commits intogroupthinking-patch-2from
copilot/review-pending-prs-another-one

Conversation

Copy link
Contributor

Copilot AI commented Feb 9, 2026

Sweeps actionable, unresolved review comments across open PRs into a single mergeable change to unblock the backlog.

Type safety (xapi.ts, grok.ts)

  • Replace string-concatenated mentions URL with URLSearchParams (includes conditional since_id)
  • Add Array.isArray() guards before parseThread() and in searchTweets() — prevents runtime crash on unexpected API shapes
  • parseThread param: anyunknown
  • grok.ts: type the API response instead of any; as anyas AgentAction['type']
// Before
return this.parseThread(response.data || []);

// After
if (!Array.isArray(response.data)) {
  console.warn('Unexpected response shape from X API (thread): data is not an array');
  return null;
}
return this.parseThread(response.data);

Agent correctness (agent.ts)

  • Process mentions oldest-first (X API returns newest-first) so Set insertion order matches chronological order for correct pruning
  • Add bounded pruning with safe { value, done } iterator destructuring (cap: 1000)

GitHub Actions permissions

  • auto-label.yml: pull-requests: write
  • issue-triage.yml: issues: write
  • pr-checks.yml: pull-requests: write, remove .py from node -c syntax check

Docs

  • README.md: fix double-space typo, clean up wording

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits February 9, 2026 18:16
- xapi.ts: Use URLSearchParams for mentions URL with since_id support
- xapi.ts: Add Array.isArray() guard before parseThread() in fetchThread
- xapi.ts: Add Array.isArray() guard in searchTweets
- xapi.ts: Change any to unknown in parseThread parameter type
- agent.ts: Process mentions oldest-first and add safe iterator pruning
- grok.ts: Replace any with typed response, fix as any cast
- auto-label.yml: Add permissions: pull-requests: write
- issue-triage.yml: Add permissions: issues: write
- pr-checks.yml: Add permissions: pull-requests: write, fix syntax check
- README.md: Fix double space and improve wording

Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Copilot AI changed the title [WIP] Review and complete pending pull requests fix: consolidate unresolved review feedback from PRs #26, #6, #4, #13 Feb 9, 2026
Copilot AI requested a review from groupthinking February 9, 2026 18:19
@groupthinking
Copy link
Owner

Closing stale draft — superseded by cleanup/ready-to-use merge to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants