Skip to content

Fix clearTimeout timer leaks in AbortController fetch patterns #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
groupthinking merged 4 commits into from
Feb 27, 2026
Merged

Fix clearTimeout timer leaks in AbortController fetch patterns #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ec87f3
Initial plan
Copilot Feb 27, 2026
8847930
Fix clearTimeout not called in finally blocks for AbortController tim…
Copilot Feb 27, 2026
8e6ae78
Merge branch 'claude/slack-check-status-update-R47Ph' into copilot/su…
groupthinking Feb 27, 2026
2b9c1f4
Merge branch 'main' into copilot/sub-pr-33-another-one
groupthinking Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions apps/web/src/app/api/video/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,17 @@ export async function POST(request: Request) {
const controller = new AbortController();
const timeout = setTimeout(() => controller.abort(), 15_000);

const response = await fetch(`${BACKEND_URL}/api/v1/transcript-action`, {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({ video_url: url, language: 'en' }),
signal: controller.signal,
}).finally(() => clearTimeout(timeout));
let response: Response;
try {
response = await fetch(`${BACKEND_URL}/api/v1/transcript-action`, {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({ video_url: url, language: 'en' }),
signal: controller.signal,
});
} finally {
clearTimeout(timeout);
}

if (response.ok) {
const result = await response.json();
Expand Down
264 changes: 0 additions & 264 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading