Skip to content

Fix timeout leak, transcript_segments shape mismatch, and ENABLE_VERTEX_AI boolean guard #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
groupthinking merged 5 commits into from
Feb 27, 2026
Merged

Fix timeout leak, transcript_segments shape mismatch, and ENABLE_VERTEX_AI boolean guard #34

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b0629d7
Initial plan
Copilot Feb 27, 2026
bb808ff
Fix review feedback: timeout cleanup, transcript_segments shape, ENAB…
Copilot Feb 27, 2026
d59ce5d
Merge branch 'claude/slack-check-status-update-R47Ph' into copilot/su…
groupthinking Feb 27, 2026
e95ce42
Merge branch 'claude/slack-check-status-update-R47Ph' into copilot/su…
groupthinking Feb 27, 2026
8b96dce
Merge branch 'main' into copilot/sub-pr-33
groupthinking Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/web/src/app/api/video/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,10 @@ export async function POST(request: Request) {
// Works on Vercel without the Python backend by chaining the serverless
// /api/transcribe and /api/extract-events routes directly.

// Use trusted backend origin instead of deriving from potentially user-controlled request data
const origin = BACKEND_URL;

Comment on lines +107 to +109
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

origin is declared but never used, and the surrounding comment suggests the code is avoiding deriving an origin from the incoming request. As written, the route still derives baseUrl from request.url for the internal /api/transcribe and /api/extract-events calls, so this is dead code and potentially misleading. Either remove origin/the comment, or actually use a trusted, configured app origin when building those internal URLs (and rename the variable accordingly).

Suggested change
// Use trusted backend origin instead of deriving from potentially user-controlled request data
const origin = BACKEND_URL;

Copilot uses AI. Check for mistakes.
// Step 1: Get transcript
let transcript = '';
let transcriptSource = 'none';
try {
Expand Down
Loading