Skip to content

DAOS-623 dlog cleanup #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
grom72 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

DAOS-623 dlog cleanup #74

grom72 wants to merge 4 commits into from

Conversation

@grom72
Copy link
Owner

@grom72 grom72 commented Feb 3, 2025 •
edited
Loading

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

This change is Reviewable

@grom72 grom72 force-pushed the grom72/daos-623-dlog-cleanup branch from 38980f6 to 941ef8e Compare February 3, 2025 09:20
grom72
grom72 commented Feb 3, 2025
View reviewed changes
Copy link
Owner Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

grom72 added 4 commits February 3, 2025 12:18
@grom72
DAOS-623 cq: _D_DEBUG_W_SAVED_MASK intro
c5d6832 
Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Delete obsolete macro
8cb146a 
Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Harmonize _D_DEBUG* macro parameters name
8e7299b 
Harmonize _D_DEBUG* and _D_LOG_CHECK* macros parameters name with
documentation:

level - log message priority and debug bits/mask
flags - complete logging information including  message priority,
	facility and additional flags like per-message log flag
	values (e.g. DLOG_STDERR)

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Unified clog_unlock() in case of dlog_print_err
110fb36 
Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72 grom72 force-pushed the grom72/daos-623-dlog-cleanup branch from 2bd6120 to 110fb36 Compare February 3, 2025 11:19
grom72
grom72 commented Feb 3, 2025
View reviewed changes
Copy link
Owner Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r5.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @grom72)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grom72