Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.yml #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update install.yml #6

wants to merge 1 commit into from

Conversation

gpapadoka
Copy link
Collaborator

Trashbin retention 35 days

Trashbin retention 35 days
Copy link
Collaborator

@aptiko aptiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since team-collaboration-toolkit is not specifically for us, but for general use, it doesn't seem right to hardwire our own special requirements. Since this parameter already has a default in nextcloud, "auto", we shouldn't specify another default here. What we should do instead is add a nextcloud_trashbin_retention_obligation parameter to the nextcloud role, which by default will have the same value as the upstream default, i.e. "auto", and use that parameter in our own Ansible playbook.

(Incidentally, I think I haven't named the parameters of the nextcloud role well, they should all have a nextcloud_ prefix.)

BTW, again, I think a better commit message is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants