Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFN2: Multipole Electrostatics (AES2) #204

Merged
merged 11 commits into from
Mar 3, 2025
Merged

GFN2: Multipole Electrostatics (AES2) #204

merged 11 commits into from
Mar 3, 2025

Conversation

marvinfriede
Copy link
Member

  • Fix moment operator shift for quadrupole integral
  • Multipole electrostatics (energy, potential
  • Refactor Interaction API
  • Fix energies being calculated after mixing (now before mixing, returned energy is now always before mixing)

@marvinfriede marvinfriede mentioned this pull request Mar 2, 2025
7 tasks
Copy link

codecov bot commented Mar 2, 2025

Codecov Report

Attention: Patch coverage is 80.24691% with 80 lines in your changes missing coverage. Please review.

Project coverage is 84.60%. Comparing base (3436350) to head (e98d79c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../_src/components/interactions/coulomb/multipole.py 82.85% 31 Missing and 5 partials ⚠️
src/dxtb/_src/scf/unrolling/default.py 39.13% 10 Missing and 4 partials ⚠️
src/dxtb/_src/scf/base.py 53.84% 11 Missing and 1 partial ⚠️
src/dxtb/_src/integral/container.py 61.53% 5 Missing and 5 partials ⚠️
src/dxtb/_src/integral/types/quadrupole.py 80.76% 2 Missing and 3 partials ⚠️
src/dxtb/_src/scf/implicit/default.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   84.08%   84.60%   +0.52%     
==========================================
  Files         200      201       +1     
  Lines        9864    10042     +178     
  Branches     1134     1137       +3     
==========================================
+ Hits         8294     8496     +202     
+ Misses       1216     1185      -31     
- Partials      354      361       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marvinfriede marvinfriede merged commit 26ffb72 into main Mar 3, 2025
73 of 74 checks passed
@marvinfriede marvinfriede deleted the gfn2-es2 branch March 3, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant