Skip to content

bump project deps, inline-snapshot config, add templates #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2025

Conversation

grillazz
Copy link
Owner

@grillazz grillazz commented Jun 7, 2025

No description provided.

@grillazz grillazz requested a review from Copilot June 7, 2025 07:37
@grillazz grillazz self-assigned this Jun 7, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps various project dependencies, adds inline-snapshot tool configuration, and introduces an HTML template with a corresponding FastAPI endpoint.

  • Updated dependency versions in pyproject.toml and adjusted Makefile snapshot flags.
  • Added templates/index.html and a new /index route using Jinja2Templates.
  • Updated compose.yml and Dockerfile to mount and copy the templates directory and pyproject.toml.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
templates/index.html Added a Tabler-based HTML template for the app
pyproject.toml Bumped versions and configured tool.inline-snapshot
compose.yml Mounted app, tests, and templates directories for development
app/main.py Integrated Jinja2Templates, added /index endpoint, commented scheduler setup
Makefile Changed inline-snapshot invocation from create to fix
Dockerfile Copied templates/ and pyproject.toml into the image
Comments suppressed due to low confidence (2)

app/main.py:71

  • Consider adding a test for this new /index route to verify the HTMLResponse and template rendering work as expected.
@app.get("/index", response_class=HTMLResponse)

app/main.py:76

  • [nitpick] These commented-out scheduler lines could benefit from a short TODO or comment explaining when and why they'll be re-enabled to aid future maintainers.
# _scheduler_data_store = SQLAlchemyDataStore(engine, schema="scheduler")

@grillazz grillazz merged commit 21c2a4f into main Jun 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant