Added file name, size and hash to review. #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mickel1138 Do we need to add on-change javascript? Because when the file gets updated, the information still points to the previous information |
|
@praneethpr good question. I'm gonna say no, but i'll mention it to the P.O. |
fightingtexasaggie
requested changes
Dec 7, 2018
There was a problem hiding this comment.
Tested. Looks good. Meets ticket acceptance criteria. The only problem I found is that the sha hash might not have yet been processed by the consumer, which actually results in preventing the view or review mode from working altogether. To see this, null out the hash in the database. I attempted adding a | default to the template, but that didn't fix the behavior.
|
@fightingtexasaggie this is the correct behaviour, if there is not hash, the submission can not be reviewed. |
fightingtexasaggie
previously approved these changes
Dec 7, 2018
…-to-review Conflicts: src/Pelagos/Bundle/AppBundle/Controller/UI/DatasetReviewController.php
praneethpr
approved these changes
Dec 10, 2018
fightingtexasaggie
approved these changes
Dec 10, 2018
mickel1138
deleted the
feature/PELAGOS-3413-add-file-information-to-review
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PELAGOS-3412 will modify the same file, so watch out for merge conflicts.