Endpoint to get modifications from composite together with the modifications not found

[FranckLecuyer]

PR Summary

Add new endpoint to get modifications from composite modifications, together with the composite modifications not found.

[antoinebhs]

I think we can simplify a lot the code by adding a method to the repository and removing the metadata

[coderabbitai]

♻️ Duplicate comments (1)

src/main/java/org/gridsuite/modification/server/repositories/ModificationRepository.java (1)

81-82: ⚠️ Potential issue | 🟠 Major

Existence check still excludes empty composites.

On Line 81, existence is derived from the sub-modification join table, so a valid composite with zero children is reported as missing. Query the composite entity/table directly instead.

Suggested fix

-    `@Query`(value = "SELECT DISTINCT cast(id AS VARCHAR) FROM composite_modification_sub_modifications WHERE id IN (?1)", nativeQuery = true)
+    `@Query`("SELECT c.id FROM CompositeModificationEntity c WHERE c.id IN (?1)")
     Set<UUID> findExistingCompositeModificationIds(List<UUID> compositeIds);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@src/main/java/org/gridsuite/modification/server/repositories/ModificationRepository.java`
around lines 81 - 82, The current repository method
findExistingCompositeModificationIds queries the join table
composite_modification_sub_modifications, which omits composites that have no
sub-modifications; change the query to select IDs directly from the composite
entity/table (the composite modification table, e.g., composite_modification)
using the provided compositeIds parameter so empty composites are included in
the existence check; update the `@Query` on findExistingCompositeModificationIds
to query the composite table by id IN (?1) and return the Set<UUID>.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In
`@src/main/java/org/gridsuite/modification/server/repositories/ModificationRepository.java`:
- Around line 81-82: The current repository method
findExistingCompositeModificationIds queries the join table
composite_modification_sub_modifications, which omits composites that have no
sub-modifications; change the query to select IDs directly from the composite
entity/table (the composite modification table, e.g., composite_modification)
using the provided compositeIds parameter so empty composites are included in
the existence check; update the `@Query` on findExistingCompositeModificationIds
to query the composite table by id IN (?1) and return the Set<UUID>.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 20618273-84ba-4ee3-a938-e4b47ea7bd6b

📥 Commits

Reviewing files that changed from the base of the PR and between 4bde5f8 and a8cde7a.

📒 Files selected for processing (2)

• src/main/java/org/gridsuite/modification/server/repositories/ModificationRepository.java
• src/main/java/org/gridsuite/modification/server/service/NetworkModificationService.java

🚧 Files skipped from review as they are similar to previous changes (1)

• src/main/java/org/gridsuite/modification/server/service/NetworkModificationService.java

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[antoinebhs]

Code ok 👍