Fix : crash of the SLD/SND when displaying a transfo tooltip

[Mathieu-Deharbe]

tapPosition used to an index and is now a key -> this means that lowTapPosition shouldn't be used anymore to determine the step

[coderabbitai]

📝 Walkthrough

Walkthrough

Tooltip tap-changer characteristics now index steps by tapPosition directly (instead of tapPosition - lowTapPosition) for both ratio (rho) and phase (alpha), retaining rendered tap values and the '-' fallback for missing entries.

Changes

Cohort / File(s)	Summary
Tap Changer Tooltip src/components/tooltips/branch/twt-tap-changer-characteristics.tsx	Replaced offset-based indexing steps[tapPosition - lowTapPosition] with direct steps[tapPosition] for ratio (rho) and phase (alpha) lookups. Kept existing tap rendering and '-' fallback for absent alpha/rho values. Lines changed: +2/-2.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title is related to the changeset, describing a crash fix in SLD/SND transformer tooltips, which aligns with the fix for tap changer characteristics data lookup.
Description check	✅ Passed	The description explains the root cause of the changes: tapPosition changed from being an index to a key, making lowTapPosition obsolete, which directly relates to the modifications made.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/components/tooltips/branch/twt-tap-changer-characteristics.tsx`:
- Line 28: The falsy check on ratioTapChanger.tapPosition treats 0 as absent
causing rho/alpha to show '-' incorrectly; update the ternary expressions that
set rho and alpha (the lines referencing ratioTapChanger.tapPosition and
ratioTapChanger.steps) to test for null/undefined explicitly (e.g., tapPosition
!== null && tapPosition !== undefined) before indexing steps so a valid
tapPosition of 0 returns the real value instead of '-'.
- Around line 27-28: The tap handling is inconsistent: `tap` is set directly
from `ratioTapChanger.tapPosition` while `rho` uses `?? '-'`, causing
`Math.round(r.tap)` (in the code that processes rows) to blow up if `tap` is
null/undefined. Change the assignment to use consistent nullish coalescing
(e.g., `tap: ratioTapChanger.tapPosition ?? '-'`), and make the code that rounds
taps robust by only calling `Math.round` when the value is numeric (e.g.,
`typeof r.tap === 'number' ? Math.round(r.tap) : r.tap`) so
`ratioTapChanger.tapPosition`, the `rho` field, and the `Math.round(r.tap)`
usage are all handled safely and consistently.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d3e310b0-0a35-4155-a114-904871651db2

📥 Commits

Reviewing files that changed from the base of the PR and between 87d5c94 and f2b5429.

📒 Files selected for processing (1)

• src/components/tooltips/branch/twt-tap-changer-characteristics.tsx

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sBouzols]

Code review OK
Test OK
Console warning check OK