Conversation
Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
📝 WalkthroughWalkthroughUpdates NetworkAreaDiagram styling and rendering configuration: adds intermediate NAD zoom thresholds, shifts adaptive text zoom threshold, expands invalid-state selectors to include NAD elements (and removes a dedicated Changes
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/grid-layout/cards/diagrams/diagram-styles.ts`:
- Line 127: The selector list inside the divDiagramLoadflowInvalid styles is
missing the nesting operator for .nad-reactive causing it to leak globally;
update the selector string that currently contains ".nad-reactive" to include
the ampersand prefix "& .nad-reactive" so it becomes nested with the other
selectors (the same selector list that starts with "& .sld-active-power, &
.sld-reactive-power, ..."). Ensure the modified selector list uses "&
.nad-reactive" to scope opacity to this component only.
In `@src/styles/dark-theme-css-vars.ts`:
- Around line 34-36: The CSS selector key string '.nad-active,
.nad-permanent-limit-percentage, .nad-bus-descr,' in dark-theme-css-vars is
invalid due to a trailing comma; remove the trailing comma from that selector
list so it reads '.nad-active, .nad-permanent-limit-percentage, .nad-bus-descr'
to match the light theme and ensure the fill: 'white' rule is applied.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 306d1e39-1664-42cd-96c1-e73de28374d1
📒 Files selected for processing (7)
src/components/grid-layout/cards/diagrams/diagram-styles.tssrc/components/grid-layout/cards/diagrams/diagram-utils.tssrc/components/grid-layout/cards/diagrams/networkAreaDiagram/network-area-diagram-content.tsxsrc/nad-index.csssrc/styles/dark-theme-css-vars.tssrc/styles/light-theme-css-vars.tssrc/utils/colors.ts
|



PR Summary
Add
PermanentLimitPercentageandActivePowerat middle edge infosAdjust some CSS for level of details by zoom level and colors