Add element not found for deleted generic filter by ghazwarhili · Pull Request #3767 · gridsuite/gridstudy-app

ghazwarhili · 2026-02-27T13:14:32Z

PR Summary

Add 'Element Not Found' for deleted generic filter

…-deleted

src/redux/globalFiltersMiddleware.ts

src/components/results/common/global-filter/global-filter-provider.tsx

src/components/results/common/global-filter/global-filter-autocomplete.tsx

src/components/results/common/global-filter/global-filter-provider.tsx

…-deleted

flomillot

Code OK

src/components/results/common/global-filter/global-filter-provider.tsx

flomillot

We don't send the updated filter but the previous version to the server.

…-deleted

…neric-filter-deleted' into add-element-not-found-case-of-generic-filter-deleted

…-deleted

…neric-filter-deleted' into add-element-not-found-case-of-generic-filter-deleted

flomillot

edit : mistake

coderabbitai · 2026-03-24T15:57:34Z

📝 Walkthrough

Walkthrough

Provider now marks missing generic global filters with a deleted flag instead of removing them, propagating that flag through types, provider logic, styles, autocomplete, option labels, chip rendering, and redux action/middleware signatures which now accept optional table metadata.

Changes

Cohort / File(s)	Summary
Provider & types `src/components/results/common/global-filter/global-filter-provider.tsx`, `src/components/results/common/global-filter/global-filter-types.ts`	Provider switched from sequential per-UUID async updates to a memoized `updateGenericFilter` + `Promise.all` batch. Missing generic filters are marked with `deleted: true` via `addToGlobalFilterOptions(..., tableType, tableUuid)`. Added optional `deleted?: boolean` to `GlobalFilter`.
Presentation & utils `src/components/results/common/global-filter/global-filter-styles.ts`, `src/components/results/common/global-filter/global-filter-autocomplete.tsx`, `src/components/results/common/global-filter/global-filter-utils.ts`, `src/components/results/common/global-filter/selected-global-filters.tsx`	`getResultsGlobalFiltersChipStyle` signature changed to accept a `GlobalFilter` and applies `chipNotFound` when `element.deleted` is true. Autocomplete and middleware exclude `deleted` options. `getOptionLabel` returns localized "elementNotFound" for deleted GENERIC_FILTER and SUBSTATION_* types. Chip rendering updated to pass full element.
Redux action & middleware `src/redux/actions.ts`, `src/redux/globalFiltersMiddleware.ts`	`AddToGlobalFilterOptionsAction` and `addToGlobalFilterOptions()` now accept optional `tableType` and `tableId`. Middleware treats `ADD_TO_GLOBAL_FILTER_OPTIONS` like other add/remove actions, computes `index = tableId ?? tableType`, aborts backend sync if `studyUuid` or `index` falsy, and excludes `deleted` entries from payload sent to backend.

Sequence Diagram

sequenceDiagram
    participant Provider as global-filter-provider
    participant Backend as Backend API
    participant Store as Redux Store
    participant UI as Chip Components

    rect rgba(100,150,200,0.5)
    Note over Provider,UI: Batch fetching and marking missing filters deleted
    end

    Provider->>Backend: Fetch generic filter(s) (parallel)
    Backend-->>Provider: 404 Not Found
    Provider->>Store: Dispatch addToGlobalFilterOptions([{...genericFilter, deleted: true}], tableType, tableUuid)
    Store-->>UI: State updated with deleted flag
    UI->>UI: getResultsGlobalFiltersChipStyle(element)
    alt element.deleted == true
        UI->>UI: Apply resultsGlobalFilterStyles.chipNotFound
    else
        UI->>UI: Apply style from FILTER_TYPE_STYLE_MAP
    end
    UI-->>Provider: Render chips with updated styles/labels

Suggested reviewers

Meklo
etiennehomer

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding support for marking generic filters as 'deleted' and displaying them as 'Element Not Found' in the UI.
Description check	✅ Passed	The description is related to the changeset, though brief. It indicates the intent to add 'Element Not Found' for deleted generic filters, which aligns with the code changes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/redux/globalFiltersMiddleware.ts`:
- Around line 37-47: The switch case handling ADD_GLOBAL_FILTERS /
ADD_TO_GLOBAL_FILTER_OPTIONS / REMOVE_GLOBAL_FILTERS / CLEAR_GLOBAL_FILTERS uses
index = tableId ?? tableType and proceeds to schedule backend syncs and call
setComputationResultGlobalFilters, markEditingGlobalFilter,
unmarkEditingGlobalFilter even when index is undefined; add an early guard in
that switch block (inside the case handling these action types in
globalFiltersMiddleware) that checks if tableType and tableId are both missing
(index == null/undefined) and if so skip the backend sync/marking logic and
simply continue (e.g., return next(action) or break), preventing calls to
setComputationResultGlobalFilters(studyUuid, undefined, ...), creation of
debouncedSyncTimers["undefined"], and
markEditingGlobalFilter/unmarkEditingGlobalFilter with undefined keys.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fe9636de-2741-4ba9-b9f1-29ab289bdc03

📥 Commits

Reviewing files that changed from the base of the PR and between f7c3f16 and 14e5d22.

📒 Files selected for processing (8)

src/components/results/common/global-filter/global-filter-autocomplete.tsx
src/components/results/common/global-filter/global-filter-provider.tsx
src/components/results/common/global-filter/global-filter-styles.ts
src/components/results/common/global-filter/global-filter-types.ts
src/components/results/common/global-filter/global-filter-utils.ts
src/components/results/common/global-filter/selected-global-filters.tsx
src/redux/actions.ts
src/redux/globalFiltersMiddleware.ts

src/redux/globalFiltersMiddleware.ts

flomillot · 2026-03-25T13:39:22Z

src/components/results/common/global-filter/global-filter-autocomplete.tsx

            const filteredOptions = options
                // Allows to find the translated countries (and not their countryCodes) when the user inputs a search value
                .filter((option: GlobalFilter) => {
+                    if (option.deleted) return false;


As described in the comment :

// Filter / sort the options 'on the fly' based on the user's search input value and the category he selected (country, voltage level, recent...)

Deleted filters should not appear whatever the input or the category.
So this code should be in the use memo below.

I totally agree
fixed

src/components/results/common/global-filter/global-filter-provider.tsx

flomillot · 2026-03-25T13:56:30Z

src/components/results/common/global-filter/global-filter-provider.tsx

+                if (path !== genericFilter.path || label !== genericFilter.label) {
+                    dispatch(
+                        addToGlobalFilterOptions(
+                            [{ ...genericFilter, path: path, label: label ?? genericFilter.label }],


This code is problematic if label is undefined. I don't remember why we have this line ?

because the find + optional chaining (?.)
if find doesn’t locate anything, it returns undefined
So this becomes: undefined?.elementName => label = undefined
fixed by
const label = response.find((parent) => parent.type === ElementType.FILTER)?.elementName ?? genericFilter.label;

flomillot · 2026-03-25T14:10:32Z

We don't send the updated filter but the previous version to the server.

This is not fixed btw.
If you manually unselect the deleted filters, then we continue to send it to the server and it's still stored in the database.

ghazwarhili · 2026-03-25T14:40:49Z

We don't send the updated filter but the previous version to the server.

This is not fixed btw. If you manually unselect the deleted filters, then we continue to send it to the server and it's still stored in the database.

Could you resend the image? It’s not displayed, so I can’t understand your test scenario

coderabbitai

🧹 Nitpick comments (1)

src/components/results/common/global-filter/global-filter-provider.tsx (1)
100-100: Update the comment to reflect current behavior.

The comment says "remove them if they do not exist anymore" but the implementation now marks filters with deleted: true instead of removing them. This allows users to see "element not found" in the UI.
📝 Suggested comment update
-    // Check the selected global filters and remove them if they do not exist anymore.
+    // Check the selected global filters and mark them as deleted if they no longer exist.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/components/results/common/global-filter/global-filter-provider.tsx` at
line 100, Update the inline comment that currently reads "remove them if they do
not exist anymore" to reflect the current behavior: instead of removing missing
filters the code marks them with deleted: true so they remain visible in the UI
as "element not found"; change the comment near the filtering logic in
global-filter-provider.tsx (the check that processes selected global filters) to
explicitly state that missing filters are flagged with deleted: true rather than
removed.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/components/results/common/global-filter/global-filter-provider.tsx`:
- Line 100: Update the inline comment that currently reads "remove them if they
do not exist anymore" to reflect the current behavior: instead of removing
missing filters the code marks them with deleted: true so they remain visible in
the UI as "element not found"; change the comment near the filtering logic in
global-filter-provider.tsx (the check that processes selected global filters) to
explicitly state that missing filters are flagged with deleted: true rather than
removed.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 023b92bc-7271-4dd0-8c50-ae3665d14c50

📥 Commits

Reviewing files that changed from the base of the PR and between c215fb4 and 4770132.

📒 Files selected for processing (2)

src/components/results/common/global-filter/global-filter-autocomplete.tsx
src/components/results/common/global-filter/global-filter-provider.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

src/components/results/common/global-filter/global-filter-autocomplete.tsx

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/redux/globalFiltersMiddleware.ts (1)

58-70: ⚠️ Potential issue | 🟠 Major

Deleted filters can still be persisted via the selected list.

Line 69 excludes deleted filters only from recentGlobalFilters, but Line 58 still includes deleted entries in selectedGlobalFilters. If a deleted generic filter is still selected, it can still be sent in globalFilters and re-saved server-side.

💡 Proposed fix

-            const selectedGlobalFilters = state.globalFilterOptions.filter((filter) =>
-                selectedFiltersIds.includes(filter.id)
-            );
+            const selectedGlobalFilters = state.globalFilterOptions.filter(
+                (filter) => selectedFiltersIds.includes(filter.id) && !filter.deleted
+            );

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/redux/globalFiltersMiddleware.ts` around lines 58 - 70,
selectedGlobalFilters currently includes entries from state.globalFilterOptions
without excluding deleted filters, so deleted global filters can be sent back;
update the selection logic in the selectedGlobalFilters computation (the filter
over state.globalFilterOptions that uses selectedFiltersIds) to also exclude
options where opt.deleted is true (consistent with the recentGlobalFilters
check), ensuring both selectedGlobalFilters and recentGlobalFilters only
contribute non-deleted entries to globalFilters.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@src/redux/globalFiltersMiddleware.ts`:
- Around line 58-70: selectedGlobalFilters currently includes entries from
state.globalFilterOptions without excluding deleted filters, so deleted global
filters can be sent back; update the selection logic in the
selectedGlobalFilters computation (the filter over state.globalFilterOptions
that uses selectedFiltersIds) to also exclude options where opt.deleted is true
(consistent with the recentGlobalFilters check), ensuring both
selectedGlobalFilters and recentGlobalFilters only contribute non-deleted
entries to globalFilters.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7f2ce882-fcb4-4081-a8af-922816065ce5

📥 Commits

Reviewing files that changed from the base of the PR and between 4770132 and 5c141a2.

📒 Files selected for processing (1)

src/redux/globalFiltersMiddleware.ts

…-deleted

sonarqubecloud · 2026-03-26T12:38:19Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ghazwarhili added 3 commits February 27, 2026 14:13

add element for filter generic not found

2e45047

Merge branch 'main' into add-element-not-found-case-of-generic-filter…

67bfbfb

…-deleted

clean code

b8ec3f6

ghazwarhili requested a review from flomillot March 3, 2026 11:12

ghazwarhili added 2 commits March 3, 2026 12:42

renamed filter

ae6fd20

Merge branch 'main' into add-element-not-found-case-of-generic-filter…

7b35617

…-deleted

ghazwarhili changed the title ~~add element for filter generic not found~~ Add 'Element Not Found' for deleted generic filter Mar 4, 2026

ghazwarhili changed the title ~~Add 'Element Not Found' for deleted generic filter~~ Add element not found for deleted generic filter Mar 4, 2026

flomillot reviewed Mar 5, 2026

View reviewed changes

src/redux/globalFiltersMiddleware.ts Outdated Show resolved Hide resolved

src/components/results/common/global-filter/global-filter-provider.tsx Outdated Show resolved Hide resolved

src/components/results/common/global-filter/global-filter-provider.tsx Outdated Show resolved Hide resolved

remove from selected global filter

aa3d556

ghazwarhili requested a review from flomillot March 6, 2026 15:56

enhance comment

1198cb8

flomillot requested changes Mar 6, 2026

View reviewed changes

code review remarks

33c590d

ghazwarhili requested a review from flomillot March 9, 2026 12:02

refacto to fix cognitive complexity sonar issue

cb80210

flomillot requested changes Mar 10, 2026

View reviewed changes

src/components/results/common/global-filter/global-filter-provider.tsx Outdated Show resolved Hide resolved

src/components/results/common/global-filter/global-filter-provider.tsx Outdated Show resolved Hide resolved

ghazwarhili added 2 commits March 10, 2026 15:42

code review remarks

8dbf23f

fix updated generic filter

e8eae1f

flomillot reviewed Mar 10, 2026

View reviewed changes

ghazwarhili added 2 commits March 11, 2026 09:01

refacto

17cfa20

Merge branch 'main' into add-element-not-found-case-of-generic-filter…

16c722d

…-deleted

ghazwarhili requested a review from flomillot March 11, 2026 11:06

flomillot approved these changes Mar 11, 2026

View reviewed changes

src/components/results/common/global-filter/global-filter-provider.tsx Show resolved Hide resolved

flomillot self-requested a review March 11, 2026 14:09

flomillot requested changes Mar 11, 2026

View reviewed changes

fix issues

a60b836

ghazwarhili requested a review from flomillot March 12, 2026 09:05

ghazwarhili added 2 commits March 12, 2026 10:09

Merge branch 'main' into add-element-not-found-case-of-generic-filter…

626f817

…-deleted

fix sonar issue

be469e0

ghazwarhili added 6 commits March 12, 2026 10:18

Merge remote-tracking branch 'origin/add-element-not-found-case-of-ge…

cabf581

…neric-filter-deleted' into add-element-not-found-case-of-generic-filter-deleted

add removed to global filter

6189226

Merge branch 'main' into add-element-not-found-case-of-generic-filter…

a7382b9

…-deleted

rename to deleted

c9003c0

Merge remote-tracking branch 'origin/add-element-not-found-case-of-ge…

68ec1ac

…neric-filter-deleted' into add-element-not-found-case-of-generic-filter-deleted

code review remarks

b30a6e6

flomillot reviewed Mar 13, 2026

View reviewed changes

ghazwarhili added 3 commits March 13, 2026 12:44

fix for tableId undefined

1f49cb2

remove deleted filter from options

62a3a92

merge main into branch

14e5d22

coderabbitai bot reviewed Mar 24, 2026

View reviewed changes

src/redux/globalFiltersMiddleware.ts Show resolved Hide resolved

resolve conflicts issues

c215fb4

ghazwarhili requested a review from flomillot March 25, 2026 12:22

flomillot requested changes Mar 25, 2026

View reviewed changes

code review remarks

4770132

coderabbitai bot reviewed Mar 25, 2026

View reviewed changes

remove deleted filterd from recentGlobalFilters

5c141a2

coderabbitai bot reviewed Mar 26, 2026

View reviewed changes

ghazwarhili requested a review from flomillot March 26, 2026 12:18

Merge branch 'main' into add-element-not-found-case-of-generic-filter…

7dc6fc3

…-deleted

Conversation

ghazwarhili commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

flomillot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

flomillot left a comment

Choose a reason for hiding this comment

Uh oh!

flomillot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram

Suggested reviewers

❌ Failed checks (1 warning)

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

flomillot Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

ghazwarhili Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

flomillot Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

flomillot Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

ghazwarhili Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

flomillot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghazwarhili commented Mar 25, 2026

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 26, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ghazwarhili commented Feb 27, 2026 •

edited

Loading

flomillot left a comment •

edited

Loading

coderabbitai bot commented Mar 24, 2026 •

edited

Loading

flomillot commented Mar 25, 2026 •

edited

Loading