-
Notifications
You must be signed in to change notification settings - Fork 5
Manage sensitivity parameters with node built #3764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EtienneLt
wants to merge
12
commits into
main
Choose a base branch
from
manage-sensitivity-parameters-with-node-built
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ead4843
manage sensi parameters with node built
EtienneLt a503ffd
Merge branch 'main' into manage-sensitivity-parameters-with-node-built
EtienneLt cdb1545
finalize
EtienneLt f760117
Merge branch 'main' into manage-sensitivity-parameters-with-node-built
EtienneLt b4d2645
fix
EtienneLt dc9eb9e
Merge branch 'main' into manage-sensitivity-parameters-with-node-built
EtienneLt 84bda56
Merge branch 'main' into manage-sensitivity-parameters-with-node-built
EtienneLt 5cdba7d
Merge branch 'main' into manage-sensitivity-parameters-with-node-built
EtienneLt adc6667
get buildstatus from commonsui directly
EtienneLt 8d561c5
Merge branch 'main' into manage-sensitivity-parameters-with-node-built
EtienneLt b4c31d7
Merge branch 'main' into manage-sensitivity-parameters-with-node-built
EtienneLt e9a72ae
fix
EtienneLt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isBuiltCurrentNodecurrently treats unknown status as builtBecause
globalBuildStatusis optional,undefinedcan reach this check and evaluates totruewith the current negated comparisons. That can enable Security Analysis on nodes with unknown build state.Proposed fix
isBuiltCurrentNode={ - currentNodeBuildStatus !== BuildStatus.NOT_BUILT && - currentNodeBuildStatus !== BuildStatus.BUILDING + currentNodeBuildStatus != null && + currentNodeBuildStatus !== BuildStatus.NOT_BUILT && + currentNodeBuildStatus !== BuildStatus.BUILDING }📝 Committable suggestion
🤖 Prompt for AI Agents