Open
Conversation
Meklo
changed the title
dbraquart
requested changes
Jul 4, 2024
Contributor
dbraquart
left a comment
dbraquart
left a comment
There was a problem hiding this comment.
code: elementExists to remove
tests: partially done, sounds OK. To be continued after merge wConflcts + CR
| }} | ||
| activeDirectory={activeDirectory} | ||
| fetchAppsAndUrls={fetchAppsAndUrls} | ||
| elementExists={elementExists} |
Contributor
There was a problem hiding this comment.
elementExists is no more part of this component in commons-ui
| onClose={handleCloseDialog} | ||
| activeDirectory={activeDirectory} | ||
| fetchAppsAndUrls={fetchAppsAndUrls} | ||
| elementExists={elementExists} |
Contributor
There was a problem hiding this comment.
same here, many places where we have to remove elementExists prop
src/utils/rest-api.js
Outdated
| @@ -10,7 +10,13 @@ import { store } from '../redux/store'; | |||
| import ReconnectingWebSocket from 'reconnecting-websocket'; | |||
Contributor
There was a problem hiding this comment.
elementExists should be removed from here
Tristan-WorkGH
force-pushed
the
feat/remove_fetch_utils
branch
from
09b8cf0 to
0140385
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need #475
Depends on gridsuite/commons-ui#455