Adaptation to moving DS Params to DS server

[thangqp]

PR Summary

Adapt types of params with field id

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c3f142cb-464c-4dc7-a3ab-7d2da760ff4d

📥 Commits

Reviewing files that changed from the base of the PR and between 3b5f4c3 and 03afbb0.

📒 Files selected for processing (1)

• src/utils/types/dynamic-simulation.type.ts

---

📝 Walkthrough

Walkthrough

This pull request refactors type definitions in the dynamic simulation module. It renames the SolverTypeInfos enum to SolverType, strengthens ID types from string to UUID, changes solver linkage from solverId: string to solver: SolverType, and updates discrimination logic to use the type field instead of a name field.

Changes

Cohort / File(s)	Summary
Type Definition Refactoring src/utils/types/dynamic-simulation.type.ts	Renamed enum SolverTypeInfos to SolverType; strengthened ID typing to UUID in CommonSolverInfos, DynamicSimulationParametersInfos, and CurveInfos; replaced solverId: string with solver: SolverType in DynamicSimulationParametersInfos; updated solver type discrimination from name field to type: SolverType enum values.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main architectural change of adapting types to accommodate moving DS parameters to the DS server, though it could be more specific about type changes.
Description check	✅ Passed	The description directly relates to the changeset, stating 'Adapt types of params with field id', which aligns with the addition of optional id fields to various types.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud