gw-conditional-logic-operator-does-not-contain.php: Fixed an issue with the snippet.

[saifsultanc]

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2939080775/83427

Summary

The “Does Not Contain” and "Is In" Conditional Logic Operator snippets throws a JavaScript error on non-Gravity Forms pages due to an undefined gform.addFilter function. This occurs because the snippets attempt to call gform.addFilter when the Gravity Forms context is not available.

Loom (Glenn):
https://www.loom.com/share/e6b41c2a8ea84a30b9530965ca0e873c

[coderabbitai]

Walkthrough

The conditional logic in the output_admin_inline_script methods of two Gravity Forms operator files was modified. The early return now depends on being in the admin area rather than not being in it, changing when the inline admin script is output. No public API or method signatures were changed.

Changes

File(s)	Change Summary
gravity-forms/gw-conditional-logic-operator-does-not-contain.php, gravity-forms/gw-conditional-logic-operator-is-in.php	Modified the conditional in output_admin_inline_script to check for is_admin() instead of !is_admin(), altering when the method returns early and when the inline script is output.

Possibly related PRs

• gw-conditional-logic-operator-does-not-contain.php: Added snippet for does not contain conditional logic comparison. #1073: Adds the "does not contain" operator class including the output_admin_inline_script method, which is directly modified in this PR.

Suggested reviewers

• spivurno

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0797abf and 471295f.

📒 Files selected for processing (2)

• gravity-forms/gw-conditional-logic-operator-does-not-contain.php (1 hunks)
• gravity-forms/gw-conditional-logic-operator-is-in.php (1 hunks)

🔇 Additional comments (2)

gravity-forms/gw-conditional-logic-operator-does-not-contain.php (1)

35-37: LGTM! This fix correctly addresses the JavaScript error issue.

The conditional logic change prevents the inline script from being output in admin pages that aren't Gravity Forms pages. This resolves the issue where gform.addFilter (line 44) would throw a JavaScript error when gform is undefined on non-Gravity Forms admin pages.

Logic change summary:

• Before: Script output in all admin pages
• After: Script output only in Gravity Forms admin pages or the gp-email-users page

This ensures the script only runs where the gform object is available.

gravity-forms/gw-conditional-logic-operator-is-in.php (1)

37-39: LGTM! Consistent fix implementation across both operator files.

This change mirrors the identical fix in the "Does Not Contain" operator file, ensuring consistent behavior. The modified conditional prevents the JavaScript error that would occur when gform.addFilter (line 55) is called on admin pages where Gravity Forms isn't loaded and the gform object is undefined.

The consistent implementation across both operator files maintains code uniformity and addresses the same root cause.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

	Warnings
⚠️	When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against 471295f