gw-conditional-logic-operator-does-not-contain.php: Fixed rule value for does not contain rule.

[saifsultanc]

Context

💬 Slack: https://gravitywiz.slack.com/archives/C04RQJ232PQ/p1746134330652079

Summary

The does not contain rule renders select of dropdown, instead of the text box.

David's loom explaining the issue:
https://www.loom.com/share/fc3e8050e0284dc480247ad2e35112ff

This PR adds the override for does_not_contain operator as well. Loom Demo: https://www.loom.com/share/5eeed1dd533449eab06cef3088922def

I had initially thought of the approach of using

			gform.addFilter( 'gform_conditional_logic_values_input', function( str, objectType, ruleIndex, selectedFieldId, value ) {
				const operator = jQuery( '#field_rule_operator_' + ruleIndex ).val();
				if ( operator !== 'does_not_contain' ) {
					return str;
				}
				str = '<input type="text" placeholder="' + gf_vars['enterValue'] + '" data-js-rule-input="value" class="gfield_rule_select gfield_rule_input active" id="field_rule_value_' + ruleIndex + '" name="field_rule_value_' + ruleIndex + '" value="' + value + '">';
				return str;
			} );

However, the issue with this approach was that on first render the field_rule_value_ was not defined yet, and we couldn't get does not contain to render the string instead of the dropdown of the values (for this example). It did work fine on frontend and any refresh on the values by adding/removing more rules. However, this solution was clearly lacking the correct behaviour. The issue with this approach:

https://www.loom.com/share/877e59bf2b9147e2aed59527754ec31e

[coderabbitai]

Walkthrough

This change introduces a JavaScript function within the Gravity Forms admin interface that customizes the logic determining which conditional logic operators require a text value. Specifically, it extends the default behavior by including the custom operator 'does_not_contain' among the list of operators that necessitate a text value in conditional logic rules. No other parts of the logic or public interfaces are modified.

Changes

File(s)	Change Summary
gravity-forms/gw-conditional-logic-operator-does-not-contain.php	Adds a JavaScript function to ensure the 'does_not_contain' operator is recognized as needing a text value in conditional logic rules.

Possibly related PRs

• gw-conditional-logic-operator-does-not-contain.php: Added snippet for does not contain conditional logic comparison. #1073: Introduces the full 'does_not_contain' operator implementation, including its registration and evaluation logic, complementing this PR's JavaScript-side update.

Suggested reviewers

• veryspry

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 01c2bb7 and 073c80c.

📒 Files selected for processing (1)

• gravity-forms/gw-conditional-logic-operator-does-not-contain.php (1 hunks)

🔇 Additional comments (1)

gravity-forms/gw-conditional-logic-operator-does-not-contain.php (1)

48-52: Good solution to the text input rendering issue.

This approach addresses the core issue by overriding the default Gravity Forms ruleNeedsTextValue function to include the 'does_not_contain' operator in the list of operators that require a text input. This is more reliable than the previous JavaScript filter approach since it handles the initial render correctly.

The implementation is clean and follows the same pattern as the existing Gravity Forms code. The override ensures that the "does not contain" operator will consistently render a text box input rather than a dropdown.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

	Warnings
⚠️	When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against 073c80c