fix(dialog): moved close button to the top of dialog in dom, marked caption in dialog header as h2 #2561
+9
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@PosikBoy Could u provide more detailed information in PR title? |
Contributor
|
Preview is ready. |
Contributor
|
🎭 Component Tests Report is ready. |
PosikBoy
changed the title
Contributor
Author
It was like draft) Added detailed information in title |
PosikBoy
changed the title
PosikBoy
changed the title
PosikBoy
changed the title
Alutery
reviewed
Jan 23, 2026
| <div className={b(null, className)}> | ||
| {insertBefore} | ||
| <div className={b('caption')} id={id}> | ||
| <h2 className={b('caption')} id={id}> |
Contributor
There was a problem hiding this comment.
Maybe use Text component and add as field to DialogHeaderProps? And return div as default?
Contributor
There was a problem hiding this comment.
Thanks!
Please update the PR title to reflect the last changes
amje
reviewed
Jan 27, 2026
| <div className={b(null, className)}> | ||
| {insertBefore} | ||
| <div className={b('caption')} id={id}> | ||
| <Text as={as} className={b('caption')} id={id}> |
Contributor
There was a problem hiding this comment.
Let's use variant prop subheader-3 instead of setting font styles in CSS
Contributor
|
@PosikBoy Is it best practice to put close button first in tab order? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2560