fix!: move GridItem from JS to TS#279
Merged
Merged
Conversation
ykornilov
requested review from
Marginy605,
flops and
jhoncool
as code owners
ykornilov
force-pushed
the
griditem-to-ts
branch
3 times, most recently
from
e5ebc99 to
4a0c0c4
Compare
Contributor
|
Preview is ready. |
ykornilov
force-pushed
the
griditem-to-ts
branch
from
4a0c0c4 to
79dff17
Compare
ykornilov
force-pushed
the
griditem-to-ts
branch
from
79dff17 to
31feaa9
Compare
ykornilov
changed the title
Collaborator
Author
|
The logic of determining the width/height values has been changed for the renderer plugin function |
Marginy605
requested changes
Nov 21, 2025
Comment on lines
+197
to
+201
| style && style.width !== undefined | ||
| ? Number.parseInt(String(style.width), 10) | ||
| : undefined; | ||
| const height = | ||
| style && style.height !== undefined |
Collaborator
There was a problem hiding this comment.
can be shorten as style?.width !== undefined etc
Marginy605
approved these changes
Nov 21, 2025
ykornilov
added a commit
that referenced
this pull request
Feb 13, 2026
* fix!: move GridItem from JS to TS --------- Co-authored-by: Yury Kornilov <kornilovyv@yandex-team.ru>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
* fix!: move GridLayout from JS to TS (#277) * fix!: move GridLayout from JS to TS * chore: update ci workflow --------- Co-authored-by: Yury Kornilov <kornilovyv@yandex-team.ru> * chore: move ReactGridLayout from JS to TS (#278) * chore: move ReactGridLayout from JS to TS * chore: add comments --------- Co-authored-by: Yury Kornilov <kornilovyv@yandex-team.ru> * fix!: move GridItem from JS to TS (#279) * fix!: move GridItem from JS to TS --------- Co-authored-by: Yury Kornilov <kornilovyv@yandex-team.ru> * chore: translate Item to TS (#280) Co-authored-by: Yury Kornilov <kornilovyv@yandex-team.ru> * fix!: move prepareItem from JS to TS (#284) Co-authored-by: Yury Kornilov <kornilovyv@yandex-team.ru> * fix: move withContext from JS to TS (#285) Co-authored-by: Yury Kornilov <kornilovyv@yandex-team.ru> * chore: typings refactoring (#293) * refactor: use PluginWidgetProps type for adjustWidgetLayout * refactor: deduplicate types using DashKitProps references * refactor: extract type from item prop instead of passing separately * refactor: make width and height optional in PluginWidgetProps * refactor: consolidate grid layout types in common --------- Co-authored-by: Yury Kornilov <kornilovyv@yandex-team.ru> --------- Co-authored-by: Yury Kornilov <kornilovyv@yandex-team.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.