Skip to content

fix!: move GridLayout from JS to TS #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ykornilov merged 2 commits into from
Nov 20, 2025
Merged

fix!: move GridLayout from JS to TS #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8036d77
fix!: move GridLayout from JS to TS
Nov 17, 2025
b70538a
chore: update ci workflow
Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@ name: CI

on:
push:
branches: [main, v8]
branches: [main]
pull_request:
branches: [main, v8]

jobs:
verify_files:
Expand Down
2 changes: 1 addition & 1 deletion README-ru.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ npm i @gravity-ui/dashkit @gravity-ui/uikit

```ts
type ItemManipulationCallback = (eventData: {
layout: Layouts;
layout: Layout[];
oldItem: Layout;
newItem: Layout;
placeholder: Layout;
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Plugins are required to create custom widgets.

```ts
type ItemManipulationCallback = (eventData: {
layout: Layouts;
layout: Layout[];
oldItem: Layout;
newItem: Layout;
placeholder: Layout;
Expand Down
2 changes: 1 addition & 1 deletion src/components/DashKit/DashKit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
defaultProps: defaultGridProps,
groups: groups.reduce<Record<string, GridReflowOptions>>((memo, g) => {
const groupId = g.id || DEFAULT_GROUP;
memo[groupId] = g.gridProperties

Check warning on line 99 in src/components/DashKit/DashKit.tsx

View workflow job for this annotation

GitHub Actions / Verify Files 

Assignment to property of function parameter 'memo'
? getReflowProps(g.gridProperties(defaultGridProps))
: defaultGridProps;

Expand Down Expand Up @@ -226,7 +226,7 @@
}

getItemsMeta() {
return this.metaRef.current?.getItemsMeta();
return this.metaRef.current?.getItemsMeta() ?? [];
}

reloadItems(options?: {targetIds?: string[]; force?: boolean}) {
Expand Down
Loading
Loading