Skip to content

bump hyppo version - #1092

Merged
bdpedigo merged 10 commits into
graspologic-org:mainfrom
nightosong:test
Aug 29, 2025
Merged

bump hyppo version#1092
bdpedigo merged 10 commits into
graspologic-org:mainfrom
nightosong:test

Conversation

@nightosong

@nightosong nightosong commented Oct 17, 2024

Copy link
Copy Markdown
Contributor
  • Does this PR have a descriptive title that could go in our release notes?
  • Does this PR add any new dependencies?
  • Does this PR modify any existing APIs?
  • Is the change to the API backwards compatible?
  • Have you built the documentation (reference and/or tutorial) and verified the generated documentation is appropriate?

Reference Issues/PRs

When calling a lower version of hyppo, the following error occurs, but this issue was fixed in version 0.5.1.
(or add future to dependency)

    from graspologic.partition import hierarchical_leiden
  File "/.venv/lib/python3.11/site-packages/graspologic/__init__.py", line 8, in <module>
    import graspologic.inference
  File "/.venv/lib/python3.11/site-packages/graspologic/inference/__init__.py", line 6, in <module>
    from .latent_distribution_test import latent_distribution_test
  File "/.venv/lib/python3.11/site-packages/graspologic/inference/latent_distribution_test.py", line 7, in <module>
    from hyppo.ksample import KSample
  File "/.venv/lib/python3.11/site-packages/hyppo/__init__.py", line 5, in <module>
    import hyppo.kgof
  File "/.venv/lib/python3.11/site-packages/hyppo/kgof/__init__.py", line 2, in <module>
    from .fssd import FSSD, FSSDH0SimCovObs
  File "/.venv/lib/python3.11/site-packages/hyppo/kgof/fssd.py", line 4, in <module>
    from past.utils import old_div
ModuleNotFoundError: No module named 'past'

What does this implement/fix? Briefly explain your changes.

bump hyppo

Any other comments?

@gnowland gnowland mentioned this pull request Aug 21, 2025
5 tasks
@gnowland

gnowland commented Aug 21, 2025

Copy link
Copy Markdown

Is it necessary to add both the future dep explicitely and bump hyppo? If we bump hyppo to hyppo v0.5.2 instead of v0.5.1 it will include the future dependency from neurodata/hyppo#435

@bdpedigo

Copy link
Copy Markdown
Collaborator

@gnowland you are correct I think that explicitly adding future is not necessary, I think I was messing around trying to get tests to pass but clearly did not succeed. If anyone wants to get this to a state where tests are passing I'd be more than happy to merge this

@bdpedigo

Copy link
Copy Markdown
Collaborator

and yes, we're ok with 0.5.2 now that it has MIT license again

@nightosong

Copy link
Copy Markdown
Contributor Author

@bdpedigo I’ve fixed the check issues and bumped the version to 3.4.2. Tests are now passing. This should be ready to merge.

@bdpedigo
bdpedigo self-requested a review August 29, 2025 17:27
@bdpedigo
bdpedigo merged commit 1fc4731 into graspologic-org:main Aug 29, 2025
15 checks passed
@bdpedigo

Copy link
Copy Markdown
Collaborator

thanks for the PR @nightosong and for pushing this @gnowland

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants