bump hyppo version - #1092
Merged
Merged
Conversation
|
Is it necessary to add both the future dep explicitely and bump hyppo? If we bump hyppo to hyppo v0.5.2 instead of v0.5.1 it will include the future dependency from neurodata/hyppo#435 |
Collaborator
|
@gnowland you are correct I think that explicitly adding future is not necessary, I think I was messing around trying to get tests to pass but clearly did not succeed. If anyone wants to get this to a state where tests are passing I'd be more than happy to merge this |
Collaborator
|
and yes, we're ok with 0.5.2 now that it has MIT license again |
Contributor
Author
|
@bdpedigo I’ve fixed the check issues and bumped the version to 3.4.2. Tests are now passing. This should be ready to merge. |
bdpedigo
self-requested a review
August 29, 2025 17:27
bdpedigo
approved these changes
Aug 29, 2025
Collaborator
|
thanks for the PR @nightosong and for pushing this @gnowland |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
When calling a lower version of hyppo, the following error occurs, but this issue was fixed in version 0.5.1.
(or add
futureto dependency)What does this implement/fix? Briefly explain your changes.
bump hyppo
Any other comments?