Skip to content

Fix error encountered running in helix #4123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix error encountered running in helix #4123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9851db
Fix error encountered running in helix
forivall Oct 29, 2025
923c693
Add changeset
forivall Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/poor-terms-greet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'graphql-language-service-server': patch
---

Add missing `?.` operator in loading config
2 changes: 1 addition & 1 deletion packages/graphql-language-service-server/src/MessageProcessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ export class MessageProcessor {
// TODO: eventually we will instantiate an instance of this per workspace,
// so rootDir should become that workspace's rootDir
this._settings = { ...settings, ...vscodeSettings };
const rootDir = this._settings?.load?.rootDir.length
const rootDir = this._settings?.load?.rootDir?.length
? this._settings?.load?.rootDir
: this._rootPath;
if (settings?.dotEnvPath) {
Expand Down