-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v4] Remove query
, variables
, headers
and response
props in <GraphiQL />
, <GraphiQLProvider />
and <EditorContextProvider />
#3735
base: graphiql-v4
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: d2daab6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## graphiql-v4 #3735 +/- ##
===============================================
- Coverage 67.26% 67.21% -0.05%
===============================================
Files 120 120
Lines 7019 7018 -1
Branches 2268 2275 +7
===============================================
- Hits 4721 4717 -4
- Misses 2281 2284 +3
Partials 17 17
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small, human-facing
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Not sure I want this change. I need this, since I am deep linking into our graphiql with a payload from query params. I decode this state and it contains query, variables and headers, and the editor must open in this state. Would be good to see a migration path how to solve this if this API is removed. |
per proposition #3441 (comment)