fixes #153: naming conflict when using Connection suffix#162
Closed
tomahim wants to merge 1 commit intographql-python:masterfrom
Closed
Conversation
|
thanks! saved my day. |
|
This has been already fixed. |
Collaborator
|
The issue has not been fixed in the sense that it does not need to be fixed. The way to workaround this is to avoid defining Connection for types. If you need to refer to those connections, you can access it with Closing this since this is not correct approach. |
Collaborator
|
See #153 (comment) for more context |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose to fix the #153 issue by renaming all connection classes with the suffix
Connectionas it seems to be use by thegraphene_reducer.The suffix
Connmay not be great, I'm open to other suggestions 😄