Skip to content

fixes #153: naming conflict when using Connection suffix#162

Closed
tomahim wants to merge 1 commit intographql-python:masterfrom
tomahim:fix/153-flask_sqlalchemy-example-employee-connection-naming-conflict
Closed

fixes #153: naming conflict when using Connection suffix#162
tomahim wants to merge 1 commit intographql-python:masterfrom
tomahim:fix/153-flask_sqlalchemy-example-employee-connection-naming-conflict

Conversation

@tomahim
Copy link
Copy Markdown
Contributor

@tomahim tomahim commented Aug 30, 2018

I propose to fix the #153 issue by renaming all connection classes with the suffix Connection as it seems to be use by the graphene_reducer.

The suffix Conn may not be great, I'm open to other suggestions 😄

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 91.854% when pulling 0b4c0c6 on tomahim:fix/153-flask_sqlalchemy-example-employee-connection-naming-conflict into 8872577 on graphql-python:master.

@swuecho
Copy link
Copy Markdown

swuecho commented Dec 24, 2018

thanks! saved my day.

@mfrlin
Copy link
Copy Markdown

mfrlin commented Sep 5, 2019

This has been already fixed.

@jnak
Copy link
Copy Markdown
Collaborator

jnak commented Sep 24, 2019

The issue has not been fixed in the sense that it does not need to be fixed. The way to workaround this is to avoid defining Connection for types. If you need to refer to those connections, you can access it with YourType._meta.connection. Eventually, we should expose a way to get it without accessing a private attribute.

Closing this since this is not correct approach.

@jnak jnak closed this Sep 24, 2019
@jnak
Copy link
Copy Markdown
Collaborator

jnak commented Sep 24, 2019

See #153 (comment) for more context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants