Skip to content

Conversation

theguild-bot
Copy link
Collaborator

🤖 New release

  • hive-router-query-planner: 1.0.0 -> 2.0.0 (⚠ API breaking changes)
  • hive-router-config: 0.0.4 -> 0.0.5 (✓ API compatible changes)
  • hive-router-plan-executor: 1.0.4 -> 2.0.0 (⚠ API breaking changes)
  • hive-router: 0.0.9 -> 0.0.10 (✓ API compatible changes)

hive-router-query-planner breaking changes

--- failure auto_trait_impl_removed: auto trait no longer implemented ---

Description:
A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented.
        ref: https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/auto_trait_impl_removed.ron

Failed in:
  type QueryTree is no longer Send, in /tmp/.tmp2efG2M/router/lib/query-planner/src/planner/tree/query_tree.rs:13
  type QueryTree is no longer Sync, in /tmp/.tmp2efG2M/router/lib/query-planner/src/planner/tree/query_tree.rs:13
  type ResolvedOperation is no longer Send, in /tmp/.tmp2efG2M/router/lib/query-planner/src/planner/walker/mod.rs:33
  type ResolvedOperation is no longer Sync, in /tmp/.tmp2efG2M/router/lib/query-planner/src/planner/walker/mod.rs:33
  type InDegree is no longer Send, in /tmp/.tmp2efG2M/router/lib/query-planner/src/planner/query_plan.rs:20
  type InDegree is no longer Sync, in /tmp/.tmp2efG2M/router/lib/query-planner/src/planner/query_plan.rs:20
  type FetchGraph is no longer Send, in /tmp/.tmp2efG2M/router/lib/query-planner/src/planner/fetch/fetch_graph.rs:30
  type FetchGraph is no longer Sync, in /tmp/.tmp2efG2M/router/lib/query-planner/src/planner/fetch/fetch_graph.rs:30

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/enum_variant_added.ron

Failed in:
  variant PlannerError:Cancelled in /tmp/.tmp2efG2M/router/lib/query-planner/src/planner/mod.rs:45
  variant PlannerError:Timedout in /tmp/.tmp2efG2M/router/lib/query-planner/src/planner/mod.rs:47

--- failure function_parameter_count_changed: pub fn parameter count changed ---

Description:
A publicly-visible function now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/function_parameter_count_changed.ron

Failed in:
  hive_router_query_planner::planner::walker::walk_operation now takes 5 parameters instead of 4, in /tmp/.tmp2efG2M/router/lib/query-planner/src/planner/walker/mod.rs:48
  hive_router_query_planner::planner::fetch::fetch_graph::build_fetch_graph_from_query_tree now takes 5 parameters instead of 4, in /tmp/.tmp2efG2M/router/lib/query-planner/src/planner/fetch/fetch_graph.rs:1663
  hive_router_query_planner::planner::query_plan::build_query_plan_from_fetch_graph now takes 3 parameters instead of 2, in /tmp/.tmp2efG2M/router/lib/query-planner/src/planner/query_plan.rs:76
  hive_router_query_planner::planner::best::find_best_combination now takes 3 parameters instead of 2, in /tmp/.tmp2efG2M/router/lib/query-planner/src/planner/best.rs:183

--- failure method_parameter_count_changed: pub method parameter count changed ---

Description:
A publicly-visible method now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/method_parameter_count_changed.ron

Failed in:
  hive_router_query_planner::planner::fetch::fetch_graph::FetchGraph::optimize now takes 3 parameters instead of 2, in /tmp/.tmp2efG2M/router/lib/query-planner/src/planner/fetch/optimize/mod.rs:21
  hive_router_query_planner::planner::Planner::plan_from_normalized_operation now takes 4 parameters instead of 3, in /tmp/.tmp2efG2M/router/lib/query-planner/src/planner/mod.rs:106

hive-router-plan-executor breaking changes

--- failure function_parameter_count_changed: pub fn parameter count changed ---

Description:
A publicly-visible function now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/function_parameter_count_changed.ron

Failed in:
  hive_router_plan_executor::projection::response::project_by_operation now takes 7 parameters instead of 6, in /tmp/.tmp2efG2M/router/lib/executor/src/projection/response.rs:20

--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/inherent_method_missing.ron

Failed in:
  Value::estimate_size, previously in file /tmp/.tmptfw4W5/hive-router-plan-executor/src/response/value.rs:195
Changelog

hive-router-query-planner

2.0.0 - 2025-09-30

Other

  • (deps) update dependency typescript to v5.9.3 (#462)

hive-router-config

0.0.5 - 2025-09-30

Other

  • (deps) update dependency typescript to v5.9.3 (#462)

hive-router-plan-executor

2.0.0 - 2025-09-30

Other

  • (deps) update dependency typescript to v5.9.3 (#462)

hive-router

0.0.10 - 2025-09-30

Other

  • (deps) update dependency typescript to v5.9.3 (#462)


This PR was generated with release-plz.

Copy link
Contributor

Summary of Changes

Hello @theguild-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the release process for several core hive-router components, advancing their versions and integrating a common dependency update. The primary impact is the introduction of significant breaking changes in the query-planner and plan-executor modules, which will require careful attention from consumers. Other components received minor, API-compatible updates.

Highlights

  • Major Version Bumps with Breaking Changes: The hive-router-query-planner has been updated from 1.0.0 to 2.0.0, and hive-router-plan-executor from 1.0.4 to 2.0.0. Both of these updates introduce API breaking changes, including changes to auto-trait implementations, new enum variants, and modifications to function and method parameter counts.
  • Minor Version Bumps: The hive-router package has been updated from 0.0.9 to 0.0.10, and hive-router-config from 0.0.4 to 0.0.5. These changes are API compatible.
  • Dependency Update: All affected packages now include an update to the typescript dependency to version 5.9.3.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR automates the release of several crates. My review focuses on the correctness of the versioning and changelogs.

I've found that the changelogs for hive-router-query-planner and hive-router-plan-executor are missing crucial information about breaking changes for their new major versions (2.0.0). This is a high-priority issue as users rely on changelogs to handle upgrades.

Additionally, the changelog entries for all updated crates seem to be based on an unrelated commit message about a TypeScript dependency. For hive-router and hive-router-config, which have patch bumps, this is misleading. The hive-router changelog in particular should mention that it's now using major new versions of its core dependencies.

These issues might stem from the configuration of the release automation tool. It's important to ensure that generated changelogs are accurate and informative for users.

Comment on lines +10 to +14
## [2.0.0](https://github.com/graphql-hive/router/compare/hive-router-plan-executor-v1.0.4...hive-router-plan-executor-v2.0.0) - 2025-09-30

### Other

- *(deps)* update dependency typescript to v5.9.3 ([#462](https://github.com/graphql-hive/router/pull/462))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This major version bump to 2.0.0 includes breaking changes that are not documented in the changelog. The PR description lists these changes, and they should be included here to inform users about the impact of upgrading. The current changelog entry appears to be unrelated to this crate.

Comment on lines +10 to +14
## [2.0.0](https://github.com/graphql-hive/router/compare/hive-router-query-planner-v1.0.0...hive-router-query-planner-v2.0.0) - 2025-09-30

### Other

- *(deps)* update dependency typescript to v5.9.3 ([#462](https://github.com/graphql-hive/router/pull/462))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This is a major version release (2.0.0), but the changelog is missing the list of breaking changes. The PR description details these breaking changes, and they are critical for users to understand when upgrading. Please update this changelog to include them. The current entry about a TypeScript dependency seems incorrect for this crate.

Comment on lines +10 to +14
## [0.0.10](https://github.com/graphql-hive/router/compare/hive-router-v0.0.9...hive-router-v0.0.10) - 2025-09-30

### Other

- *(deps)* update dependency typescript to v5.9.3 ([#462](https://github.com/graphql-hive/router/pull/462))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This changelog entry seems unrelated to the hive-router crate. This release updates core dependencies like hive-router-query-planner and hive-router-plan-executor to new major versions (v2.0.0) with breaking changes. This is a significant update and should be clearly communicated in the changelog, as it can affect the router's behavior.

Comment on lines +10 to +14
## [0.0.5](https://github.com/graphql-hive/router/compare/hive-router-config-v0.0.4...hive-router-config-v0.0.5) - 2025-09-30

### Other

- *(deps)* update dependency typescript to v5.9.3 ([#462](https://github.com/graphql-hive/router/pull/462))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The changelog entry about a TypeScript dependency update seems incorrect for this Rust crate. For a patch release with no user-facing changes, it would be clearer to state that it's a maintenance release, for example, by mentioning internal dependency updates.

Copy link

🐋 This PR was built and pushed to the following Docker images:

Image Names: ghcr.io/graphql-hive/router

Platforms: linux/amd64,linux/arm64

Image Tags: ghcr.io/graphql-hive/router:pr-463 ghcr.io/graphql-hive/router:sha-ac132e0

Docker metadata
{
"buildx.build.ref": "builder-b7a2b592-2de0-45f2-bb74-5e7f346bae23/builder-b7a2b592-2de0-45f2-bb74-5e7f346bae230/v9wr27ch6tsspfmfksuybqf2p",
"containerimage.descriptor": {
  "mediaType": "application/vnd.oci.image.index.v1+json",
  "digest": "sha256:4999e7c2c55efb934aa9633e9b32862efaea6a6b0bbf84e54e71424f5ad54140",
  "size": 1609
},
"containerimage.digest": "sha256:4999e7c2c55efb934aa9633e9b32862efaea6a6b0bbf84e54e71424f5ad54140",
"image.name": "ghcr.io/graphql-hive/router:pr-463,ghcr.io/graphql-hive/router:sha-ac132e0"
}

Copy link

k6-benchmark results

     ✓ response code was 200
     ✓ no graphql errors
     ✓ valid response structure

     █ setup

     checks.........................: 100.00% ✓ 239835      ✗ 0    
     data_received..................: 7.0 GB  233 MB/s
     data_sent......................: 94 MB   3.1 MB/s
     http_req_blocked...............: avg=5.06µs   min=651ns   med=1.83µs  max=6.64ms   p(90)=2.61µs  p(95)=2.98µs  
     http_req_connecting............: avg=2.22µs   min=0s      med=0s      max=6.61ms   p(90)=0s      p(95)=0s      
     http_req_duration..............: avg=18.31ms  min=1.81ms  med=17.41ms max=168.64ms p(90)=25.18ms p(95)=28.23ms 
       { expected_response:true }...: avg=18.31ms  min=1.81ms  med=17.41ms max=168.64ms p(90)=25.18ms p(95)=28.23ms 
     http_req_failed................: 0.00%   ✓ 0           ✗ 79965
     http_req_receiving.............: avg=139.81µs min=24.47µs med=39.75µs max=93.11ms  p(90)=86.67µs p(95)=361.45µs
     http_req_sending...............: avg=24.68µs  min=5.29µs  med=10.58µs max=41.42ms  p(90)=16.01µs p(95)=27.87µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s       p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=18.14ms  min=1.76ms  med=17.28ms max=76.01ms  p(90)=24.95ms p(95)=27.98ms 
     http_reqs......................: 79965   2659.610016/s
     iteration_duration.............: avg=18.75ms  min=4.79ms  med=17.77ms max=248.4ms  p(90)=25.65ms p(95)=28.73ms 
     iterations.....................: 79945   2658.944822/s
     vus............................: 50      min=50        max=50 
     vus_max........................: 50      min=50        max=50 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant