-
Notifications
You must be signed in to change notification settings - Fork 2
chore: release #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: release #463
Conversation
Summary of ChangesHello @theguild-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the release process for several core Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR automates the release of several crates. My review focuses on the correctness of the versioning and changelogs.
I've found that the changelogs for hive-router-query-planner
and hive-router-plan-executor
are missing crucial information about breaking changes for their new major versions (2.0.0). This is a high-priority issue as users rely on changelogs to handle upgrades.
Additionally, the changelog entries for all updated crates seem to be based on an unrelated commit message about a TypeScript dependency. For hive-router
and hive-router-config
, which have patch bumps, this is misleading. The hive-router
changelog in particular should mention that it's now using major new versions of its core dependencies.
These issues might stem from the configuration of the release automation tool. It's important to ensure that generated changelogs are accurate and informative for users.
## [2.0.0](https://github.com/graphql-hive/router/compare/hive-router-plan-executor-v1.0.4...hive-router-plan-executor-v2.0.0) - 2025-09-30 | ||
|
||
### Other | ||
|
||
- *(deps)* update dependency typescript to v5.9.3 ([#462](https://github.com/graphql-hive/router/pull/462)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## [2.0.0](https://github.com/graphql-hive/router/compare/hive-router-query-planner-v1.0.0...hive-router-query-planner-v2.0.0) - 2025-09-30 | ||
|
||
### Other | ||
|
||
- *(deps)* update dependency typescript to v5.9.3 ([#462](https://github.com/graphql-hive/router/pull/462)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a major version release (2.0.0), but the changelog is missing the list of breaking changes. The PR description details these breaking changes, and they are critical for users to understand when upgrading. Please update this changelog to include them. The current entry about a TypeScript dependency seems incorrect for this crate.
## [0.0.10](https://github.com/graphql-hive/router/compare/hive-router-v0.0.9...hive-router-v0.0.10) - 2025-09-30 | ||
|
||
### Other | ||
|
||
- *(deps)* update dependency typescript to v5.9.3 ([#462](https://github.com/graphql-hive/router/pull/462)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changelog entry seems unrelated to the hive-router
crate. This release updates core dependencies like hive-router-query-planner
and hive-router-plan-executor
to new major versions (v2.0.0) with breaking changes. This is a significant update and should be clearly communicated in the changelog, as it can affect the router's behavior.
## [0.0.5](https://github.com/graphql-hive/router/compare/hive-router-config-v0.0.4...hive-router-config-v0.0.5) - 2025-09-30 | ||
|
||
### Other | ||
|
||
- *(deps)* update dependency typescript to v5.9.3 ([#462](https://github.com/graphql-hive/router/pull/462)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐋 This PR was built and pushed to the following Docker images: Image Names: Platforms: Image Tags: Docker metadata{
"buildx.build.ref": "builder-b7a2b592-2de0-45f2-bb74-5e7f346bae23/builder-b7a2b592-2de0-45f2-bb74-5e7f346bae230/v9wr27ch6tsspfmfksuybqf2p",
"containerimage.descriptor": {
"mediaType": "application/vnd.oci.image.index.v1+json",
"digest": "sha256:4999e7c2c55efb934aa9633e9b32862efaea6a6b0bbf84e54e71424f5ad54140",
"size": 1609
},
"containerimage.digest": "sha256:4999e7c2c55efb934aa9633e9b32862efaea6a6b0bbf84e54e71424f5ad54140",
"image.name": "ghcr.io/graphql-hive/router:pr-463,ghcr.io/graphql-hive/router:sha-ac132e0"
} |
✅
|
🤖 New release
hive-router-query-planner
: 1.0.0 -> 2.0.0 (⚠ API breaking changes)hive-router-config
: 0.0.4 -> 0.0.5 (✓ API compatible changes)hive-router-plan-executor
: 1.0.4 -> 2.0.0 (⚠ API breaking changes)hive-router
: 0.0.9 -> 0.0.10 (✓ API compatible changes)⚠
hive-router-query-planner
breaking changes⚠
hive-router-plan-executor
breaking changesChangelog
hive-router-query-planner
hive-router-config
hive-router-plan-executor
hive-router
This PR was generated with release-plz.