Skip to content

Conversation

dotansimha
Copy link
Member

@dotansimha dotansimha commented Sep 3, 2025

Closes #439

  • fetch supergraph from CDN
  • config to fetch
  • TLS fix
  • polling interval
  • swaping of supergraph state
  • etag support
  • error handling
  • ? supergraph checksum

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @dotansimha, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the router's operational flexibility by introducing new capabilities for supergraph schema management and secure subgraph communication. It allows the router to dynamically fetch its supergraph configuration from a centralized Hive Console CDN and ensures that all interactions with subgraphs are conducted over secure HTTPS connections, improving both deployment options and data integrity.

Highlights

  • New Supergraph Source: Hive Console CDN: The router now supports fetching the supergraph schema directly from the Hive Console CDN. This introduces a new hive source type in the configuration, requiring an endpoint and an API key.
  • Enhanced HTTPS Connectivity for Subgraphs: The subgraph executors have been upgraded to utilize an HTTPS connector, improving secure communication with backend services. This change specifically integrates hyper-tls for robust TLS support in HTTP client operations.
  • Refactored Supergraph Loading Logic: The internal mechanism for loading supergraph definitions has been significantly refactored. A new SupergraphLoader trait and its implementations (SupergraphFileLoader, SupergraphHiveConsoleLoader) centralize and abstract the process of retrieving the supergraph schema, making it more flexible and extensible.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two main features: the ability to load the supergraph from a Hive CDN endpoint, and support for HTTPS connectors when communicating with subgraphs. The changes are well-structured, introducing a new supergraph module to handle different loading strategies. The implementation for HTTPS support in the executor is also correct. I have a couple of suggestions to improve robustness and error handling.

@dotansimha dotansimha mentioned this pull request Sep 3, 2025
Copy link

github-actions bot commented Sep 3, 2025

k6-benchmark results

     ✓ response code was 200
     ✓ no graphql errors
     ✓ valid response structure

     █ setup

     checks.........................: 100.00% ✓ 233895      ✗ 0    
     data_received..................: 6.8 GB  228 MB/s
     data_sent......................: 92 MB   3.0 MB/s
     http_req_blocked...............: avg=3.26µs   min=651ns   med=1.92µs  max=2.5ms    p(90)=2.78µs  p(95)=3.23µs  
     http_req_connecting............: avg=808ns    min=0s      med=0s      max=2.2ms    p(90)=0s      p(95)=0s      
     http_req_duration..............: avg=18.8ms   min=1.9ms   med=17.85ms max=227.5ms  p(90)=25.95ms p(95)=29.13ms 
       { expected_response:true }...: avg=18.8ms   min=1.9ms   med=17.85ms max=227.5ms  p(90)=25.95ms p(95)=29.13ms 
     http_req_failed................: 0.00%   ✓ 0           ✗ 77985
     http_req_receiving.............: avg=185.38µs min=26.38µs med=42.48µs max=196.32ms p(90)=95.28µs p(95)=401.81µs
     http_req_sending...............: avg=25.53µs  min=5.69µs  med=11.12µs max=20.42ms  p(90)=17.07µs p(95)=29.85µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s       p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=18.59ms  min=1.82ms  med=17.71ms max=61.53ms  p(90)=25.7ms  p(95)=28.83ms 
     http_reqs......................: 77985   2594.470557/s
     iteration_duration.............: avg=19.23ms  min=4.39ms  med=18.21ms max=267.56ms p(90)=26.42ms p(95)=29.7ms  
     iterations.....................: 77965   2593.805181/s
     vus............................: 50      min=50        max=50 
     vus_max........................: 50      min=50        max=50 

@dotansimha dotansimha force-pushed the wip-hive-source branch 2 times, most recently from abcf925 to 49564eb Compare September 4, 2025 07:50
Copy link

github-actions bot commented Sep 4, 2025

🐋 This PR was built and pushed to the following Docker images:

Image Names: ghcr.io/graphql-hive/router

Platforms: linux/amd64,linux/arm64

Image Tags: ghcr.io/graphql-hive/router:pr-400 ghcr.io/graphql-hive/router:sha-295b7dc

Docker metadata
{
"buildx.build.ref": "builder-e161f934-0d0d-4055-ae7f-f60d1d88e842/builder-e161f934-0d0d-4055-ae7f-f60d1d88e8420/phqpprz0q0r2k6l9zs68xoja1",
"containerimage.descriptor": {
  "mediaType": "application/vnd.oci.image.index.v1+json",
  "digest": "sha256:44187c9d777cd77a931736b129b572842c7df2d3ca0f3649d4388f84f3be1a7b",
  "size": 1609
},
"containerimage.digest": "sha256:44187c9d777cd77a931736b129b572842c7df2d3ca0f3649d4388f84f3be1a7b",
"image.name": "ghcr.io/graphql-hive/router:pr-400,ghcr.io/graphql-hive/router:sha-295b7dc"
}

@dotansimha dotansimha changed the title feat(router): support hive as source for supergraph, https connector feat(router): support hive as source for supergraph Sep 7, 2025
@dotansimha dotansimha marked this pull request as draft September 21, 2025 10:26
feat(config): improve file-loading for supergraph
Self {
validation_plan: graphql_tools::validation::rules::default_rules_validation_plan(),
subgraph_executor_map,
plan_cache: moka::future::Cache::new(1000),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All those caches are supergraph specific so I think RouterSharedState is already the state which lasts with the supergraph.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I plan to have a shared_state.next(new_state) that will take care of the caches as well 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hive Router + CDN usage
2 participants