Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing subgraph errors in case of nullable and non-nullable field and the inaccesible subgraph #905

Merged
merged 3 commits into from
Mar 21, 2025

Conversation

ardatan
Copy link
Member

@ardatan ardatan commented Mar 21, 2025

Ref GW-254

Verified

This commit was signed with the committer’s verified signature.
ardatan Arda TANRIKULU
@ardatan ardatan requested a review from dotansimha March 21, 2025 12:13
@ardatan ardatan marked this pull request as ready for review March 21, 2025 12:13
@ardatan ardatan changed the title Tests when subgraph is down Testing subgraph errors in case of nullable and non-nullable field and the unavailable subgraph Mar 21, 2025
@ardatan ardatan changed the title Testing subgraph errors in case of nullable and non-nullable field and the unavailable subgraph Testing subgraph errors in case of nullable and non-nullable field and the inaccesible subgraph Mar 21, 2025
ardatan added 2 commits March 21, 2025 15:46

Verified

This commit was signed with the committer’s verified signature.
ardatan Arda TANRIKULU

Verified

This commit was signed with the committer’s verified signature.
ardatan Arda TANRIKULU
@ardatan ardatan merged commit d9b4fdb into main Mar 21, 2025
57 checks passed
@ardatan ardatan deleted the subgraph-down branch March 21, 2025 13:38
}),
});
const res = await resp.json();
expect(res).toEqual({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ardatan I would expect this to be a partial response, where errors is also set?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants