Skip to content

Fix accidential change in #803 #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

Fix accidential change in #803 #804

merged 1 commit into from
Mar 10, 2025

Conversation

ardatan
Copy link
Member

@ardatan ardatan commented Mar 10, 2025

No description provided.

@ardatan ardatan merged commit b9fbc84 into main Mar 10, 2025
7 checks passed
@ardatan ardatan deleted the fix-timeout branch March 10, 2025 15:20
@theguild-bot
Copy link
Collaborator

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/batch-delegate 9.0.32-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-tools/batch-execute 9.0.13-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-tools/delegate 10.2.14-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-tools/executor-common 0.0.4-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-tools/executor-graphql-ws 2.0.4-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-tools/executor-http 1.3.0-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-tools/federation 3.1.5-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-mesh/fusion-runtime 0.11.3-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-hive/gateway 1.11.0-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-hive/logger-json 0.0.3-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-hive/logger-winston 1.0.2-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-hive/nestjs 1.0.0-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-hive/plugin-aws-sigv4 1.0.0-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-mesh/hmac-upstream-signature 1.2.22-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-opentelemetry 1.3.45-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-prometheus 1.3.33-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-hive/gateway-runtime 1.5.0-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-tools/stitch 9.4.19-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-tools/stitching-directives 3.1.29-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-common 0.7.31-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-http 0.6.35-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-http-callback 0.5.22-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-ws 1.0.5-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎
@graphql-tools/wrap 10.0.32-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e npm ↗︎ unpkg ↗︎

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Summary by CodeRabbit

  • Refactor
    • Streamlined the internal mechanism for handling request cancellations and timeouts, reducing redundant steps and ensuring more efficient processing.

Walkthrough

The pull request refactors the useUpstreamTimeout function by consolidating the creation of the abort signal. Instead of directly passing AbortSignal.any(signals) into the executor, a new variable (combinedSignal) is defined to hold this signal before being used. In addition, the redundant executor call within the Promise.race has been removed, with the executor’s result now directly participating in the promise race with the timeout promise.

Changes

File Change Summary
packages/.../useUpstreamTimeout.ts - Introduced a combinedSignal variable to hold AbortSignal.any(signals) before passing to the executor.
- Removed an extra executor call from the Promise.race to streamline execution.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5c3a9ee and 0d8bcac.

📒 Files selected for processing (1)
  • packages/runtime/src/plugins/useUpstreamTimeout.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@theguild-bot
Copy link
Collaborator

🚀 Snapshot Release (Binary for Linux-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

🚀 Snapshot Release (Binary for macOS-ARM64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

🚀 Snapshot Release (Binary for macOS-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

🚀 Snapshot Release (Binary for Linux-ARM64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

🚀 Snapshot Release (Node Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.11.0-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e

@theguild-bot
Copy link
Collaborator

🚀 Snapshot Release (Bun Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.11.0-alpha-0d8bcac818f042bcd845a8d43739c64b25fce38e-bun

@theguild-bot
Copy link
Collaborator

🚀 Snapshot Release (Binary for Windows-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ardatan @theguild-bot