-
Notifications
You must be signed in to change notification settings - Fork 134
Remove empty and unused nodes from redacted query after validation of generic-auth directives #2742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@envelop/extended-validation |
6.1.0-alpha-20251029092940-df37e7855bddbc733ddcb2d790e30e44c5cb0487 |
npm ↗︎ unpkg ↗︎ |
@envelop/generic-auth |
10.0.1-alpha-20251029092940-df37e7855bddbc733ddcb2d790e30e44c5cb0487 |
npm ↗︎ unpkg ↗︎ |
Contributor
💻 Website PreviewThe latest changes are available as preview in: https://d67c7a0b.envelop.pages.dev |
dotansimha
approved these changes
Oct 29, 2025
ardatan
approved these changes
Oct 29, 2025
Member
ardatan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the failing skipped tests, and enabled them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Causing issues with graphql-hive/gateway#1629 due to malformed queries for query planning.
The generic-auth plugin leaves document nodes broken after validation and redaction of unauthenticated fields. Given a schema:
the following user query:
{ public person { name ... on Admin { email } } }will be incorrectly redacted to:
{ public person { name - ... on Admin } }secondly, the following query:
{ public person { ... on Admin { email } } }will be incorrectly redacted to:
{ public - person { - ... on Admin - } }finally, the following query:
{ public person { ...A } } fragment A on Admin { email }will be incorrectly redacted to:
query { public - person { - ...A - } } - fragment A on AdminTODO
While working on the task, I noticed more issues with the generic-plugin itself (was broken without the fixes too) see skipped tests in
use-generic-auth.spec.ts.