Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IReadOnlyDictionry is not a list type #270

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

clangelov
Copy link
Contributor

This is one is more or less extending a previous PR:
#262

There we changed the ReflectionExtensions so
IDictionary and IDictionary<,> are not regarded as ListType
unfortunately we left over the board IReadOnlyDictionary<,> which also should not be regarded as ListType

@clangelov
Copy link
Contributor Author

@tlil @Shane32 Should I update the TargetFramework of GraphQL.Conventions.Tests to net7.0? so the action that runs the tests to pass?
is see that limitation over here: https://github.com/graphql-dotnet/conventions/actions/runs/12904851082/workflow
dotnet-version: 7.0.x

@Shane32
Copy link
Member

Shane32 commented Jan 22, 2025

@tlil @Shane32 Should I update the TargetFramework of GraphQL.Conventions.Tests to net7.0? so the action that runs the tests to pass? is see that limitation over here: https://github.com/graphql-dotnet/conventions/actions/runs/12904851082/workflow dotnet-version: 7.0.x

Fine with me.

Copy link
Member

@Shane32 Shane32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's see if @tlil or anyone else has any comments before merging.

@clangelov
Copy link
Contributor Author

@tlil can you take a look?

@Shane32
Copy link
Member

Shane32 commented Feb 11, 2025

I'll merge and release it

@Shane32 Shane32 merged commit b21837c into graphql-dotnet:master Feb 11, 2025
3 checks passed
@Shane32
Copy link
Member

Shane32 commented Feb 11, 2025

@clangelov released as 8.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants