Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error-handling.md #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update error-handling.md #45

wants to merge 3 commits into from

Conversation

jasonkarns
Copy link

Text refers to RescueRegistry gem but the code snippet is subclassing GraphitiErrors. I assume the code snippet is just out of date?

@jasonkarns
Update error-handling.md
7ad70c7 
Text refers to RescueRegistry gem but the code snippet is subclassing GraphitiErrors. I assume the code snippet is just out of date?
@jasonkarns jasonkarns mentioned this pull request May 25, 2022
Closed
jasonkarns added 2 commits May 25, 2022 14:31
@jasonkarns
Document detail option instead of message
9b42aaa 
rescue_registry gem prefers :detail option over :message.
@jasonkarns
Recommend graphiti-rails' exception handler
01ad850 
If an app is using graphiti-rails, it is presumably preferable to subclass `Graphiti::Rails::ExceptionHandler` instead of `RescueRegistry::ExceptionHandler`
@jasonkarns
Copy link
Author

Updated this PR per discussion from wagenet/rescue_registry#47

  • Replaces references to the :message option with :detail (per rescue_registry)
  • replaces GraphitiErrors ExceptionHandler base class with RescueRegistry's
  • makes note to recommend Graphiti::Rails::ExceptionHandler if in rails

Zooip
Zooip suggested changes Jul 20, 2022
View reviewed changes
Copy link

@Zooip Zooip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to compile your changes first (see Readme.md)

Zooip
Zooip approved these changes Jul 20, 2022
View reviewed changes
Copy link

@Zooip Zooip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, it's done in CI, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zooip Zooip Zooip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonkarns @Zooip