Replace charged language "whitelist/blacklist" #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 24c862d.
…d_metrics in web components
Current coverage is 65.61% (diff: 95.23%)@@ master #1700 diff @@
==========================================
Files 54 54
Lines 6122 6122
Methods 0 0
Messages 0 0
Branches 1210 1210
==========================================
Hits 4017 4017
Misses 1892 1892
Partials 213 213
|
|
I'm pushing this back to the next milestone for now. I would like to see this go in but after working on it for a day I feel like there's room for improvement in terms of naming clarity. I've gone through it a few times and caught myself getting confused with some of the functions/settings. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
3 tasks
5 tasks
deniszh
added a commit
to deniszh/graphite-web
that referenced
this pull request
Feb 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #1570, fixing a merge conflict.
Addressing #1569
Related to graphite-project/carbon#567 / graphite-project/carbon#568