-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow older gramps versions to see (not crash) db schema 21 #1974
base: maintenance/gramps60
Are you sure you want to change the base?
Conversation
It looks like you didn't initialise the blob version for new databases. I am getting the error: |
Are you sure this went through the upgrade? You can force it by removing the json_data in the metadata table. |
Oh, I see... it only works on the upgrade. Needs to always work. |
@Nick-Hall, ok I believe I have all of the paths correct now. I tested a 6.0 newly create DB, opened in 5.2, and an upgraded 6.0 in 5.2. Both complained about the version 21. |
Now I get a problem reading the name formats in the metadata table. It doesn't give me an error regarding incompatible versions. Steps to reproduce:
|
I'm going to propose some changes to earlier version of Gramps that we check the version number before trying to read the rest of the metadata. Currently gramps5.2 , it checks the version AFTER it reads in a bunch of data. Let's move the check up before that, and release new versions. |
Do we really want to release updates to old versions? How far back would we go? People probably wouldn't upgrade and would still get the errors. Can we add pickled empty lists to the rows still causing a problem? |
I can try. I'll look at that this weekend. |
@dsblank Don't spend too much time on this one. It mainly affects developers and doesn't corrupt the database. |
Older versions of Gramps cannot see the new db format (21) but just crashes.
This PR:
value
column of typeBLOB
to metadataFixes #13633