-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor proxies #1952
base: master
Are you sure you want to change the base?
Refactor proxies #1952
Conversation
Co-authored-by: stevenyoungs <[email protected]>
The speedups are great, but is there a way to make this work while still having proxy DBs inherit from If not a common base class, we would need a protocol I think. |
So these are wrappers, not subclasses. The difference is that these don't need to re-implement methods that are
That sounds like a fine PR to propose. |
This PR (targeting 6.1) is a refactor of the proxies to solve the following issues.
These new proxies:
Speed results:
On a database of 44k people, here are the timing results of this PR (6.1) versus 6.0. Times are in seconds. Times are +/- a few seconds.
Note that for all but the last row, the times are very similar. The real benefit is with nested proxies, which is common for export and the narrative report. Here we see that this PR beats 6.0 by over 13x. That is the difference between waiting 7 minutes, versus 30 seconds.