New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy: Simplify RelationshipPathBetween.prepare() #1949

Open

stevenyoungs wants to merge 1 commit into gramps-project:maintenance/gramps60 from stevenyoungs:relationshippathbetween-prepare

Contributor

stevenyoungs commented Feb 9, 2025

mypy complains about the code in its current form:

gramps/gen/filters/rules/person/_relationshippathbetween.py:71: error: Item "None" of "Person | None" has no attribute "handle"  [union-attr]
gramps/gen/filters/rules/person/_relationshippathbetween.py:72: error: Item "None" of "Person | None" has no attribute "handle"  [union-attr]

Simplify the code and fix the mypy errors


          Simplify RelationshipPathBetween.prepare

b436b0f

Don't use expcetions for non-exceptional behaviour

stevenyoungs mentioned this pull request

Add type hints to db classes #1919

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet