mypy: Simplify HasSourceOfBase.prepare() #1948
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenyoungs
force-pushed
the
hassourceofbase-prepare
branch
from
3741acf to
45eaae8
Compare
It is not expcetional for db.get_source_from_gramps_id to return None so handle with a try block
stevenyoungs
force-pushed
the
hassourceofbase-prepare
branch
from
45eaae8 to
ae4e258
Compare
stevenyoungs
commented
Feb 9, 2025
stevenyoungs
changed the title
stevenyoungs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypy complains about the current code
gramps/gen/filters/rules/_hassourceofbase.py:69: error: Item "None" of "Source | None" has no attribute "handle" [union-attr]so refactor and simplify to fix.
Exceptions are for exceptional behaviour. db.get_source_from_gramps_id returning None is not exceptional, so just handle it.