-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Relationship Calculator and Add a Searchbar #1882
Open
stevenyoungs
wants to merge
6
commits into
gramps-project:master
Choose a base branch
from
stevenyoungs:relcalc-searchbar
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor Relationship Calculator and Add a Searchbar #1882
stevenyoungs
wants to merge
6
commits into
gramps-project:master
from
stevenyoungs:relcalc-searchbar
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to crash the existing relationship calculator tool
An error similar to the below will be generated
In Windows AIO at least, there is a never ending stream of errors. The only escape is to kill the gramps process. |
36bb022
to
10031e4
Compare
10031e4
to
5f58ce1
Compare
This is framework for future changes
This allows a subclass to set the attributes
- now based on SelectPerson - includes search bar to aid finding the other person - supports changes in active person - handles database change (the previous tool crashes)
5f58ce1
to
cadaa00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the relationship calculator tool
SelectPerson
previously the calculator had it's own implementation of a person tree
BaseSelector
andSelectPerson
classes updated to support modal or modeless operation. All existing use use remains modalRelated discourse discussion, including user request: https://gramps.discourse.group/t/adding-search-bar-to-select-person-dialog/6845/10?u=stevey