Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GedcomExtensions] Allow exporting only one type of surnames #634

Open
wants to merge 2 commits into
base: maintenance/gramps52
Choose a base branch
from

Conversation

bryndin
Copy link
Contributor

@bryndin bryndin commented Jan 15, 2025

Bug: https://gramps-project.org/bugs/view.php?id=13575

In Gramps surnames can be tagged with "inherited", "taken", "patronymic" etc. That tagging is not supported by GEDCOM and is lost during the export. The surnames end up space separated and create confusion when imported to other services (e.g. Geni, FamilySearch, etc.)

Example:
Maria (given) Skłodowska (inherited surname) Curie (taken surname)
0 @I0003@ INDI 1 NAME Maria /Skłodowska Curie/ 2 TYPE birth 2 GIVN Maria 2 SURN Skłodowska, Curie

Fyodor (given), Dostoevsky(inherited surname) Mikhailovich (patronymic surname)
```
0 @I0004@ INDI
1 NAME Fyodor /Dostoevsky Mikhailovich/
2 TYPE birth
2 GIVN Fyodor
2 SURN Dostoevsky, Mikhailovich
```

It's customary in gene research to only use "maiden" names and many services expect that. Thus Gramps needs an option to export only one type of surname, e.g. inherited

Maria (given) Skłodowska (inherited surname) Curie (taken surname)
```
0 @I0003@ INDI
1 NAME Maria /Skłodowska/
2 TYPE birth
2 GIVN Maria
2 SURN Skłodowska
```

Fyodor (given), Dostoevsky(inherited surname) Mikhailovich (patronymic surname)
```
0 @I0004@ INDI
1 NAME Fyodor /Dostoevsky/
2 TYPE birth
2 GIVN Fyodor
2 SURN Dostoevsky
```

@bryndin
Copy link
Contributor Author

bryndin commented Jan 15, 2025

UI change

before
image

after
image

@bryndin
Copy link
Contributor Author

bryndin commented Jan 15, 2025

Testing

Chunks of GEDCOM file, before the change and after the filtering by inherited surname type.

before

0 @I0003@ INDI
1 NAME Maria /Skłodowska Curie/
2 TYPE birth
2 GIVN Maria
2 SURN Skłodowska, Curie
1 SEX F
1 DEAT Y
0 @I0004@ INDI
1 NAME Fyodor /Dostoevsky Mikhailovich/
2 TYPE birth
2 GIVN Fyodor
2 SURN Dostoevsky, Mikhailovich
1 SEX M
1 DEAT Y

after

0 @I0003@ INDI
1 NAME Maria /Skłodowska/
2 TYPE birth
2 GIVN Maria
2 SURN Skłodowska
1 SEX F
1 DEAT Y
0 @I0004@ INDI
1 NAME Fyodor /Dostoevsky/
2 TYPE birth
2 GIVN Fyodor
2 SURN Dostoevsky
1 SEX M
1 DEAT Y

@@ -181,10 +204,19 @@ def get_option_box(self):
self.process_patronymic_list.append_text(_("Add Patronymic name after Given name"))
self.process_patronymic_list.append_text(_("Ignore Patronymic name"))

hbox2 = Gtk.Box(orientation=Gtk.Orientation.HORIZONTAL, spacing=10)
label2 = Gtk.Label(label=_("Keep one type of surnames:"))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads better as Type of "surname" to use:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear what "to use" is in this case. It needs to be more descriptive.
Another option is "Include only this type of surname" to match the "Include..." pattern of other items.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bryndin
Copy link
Contributor Author

bryndin commented Jan 24, 2025

@daleathan thank you for updating the docs! FYI I also have this change in works

@bryndin
Copy link
Contributor Author

bryndin commented Jan 31, 2025

@GaryGriffin since you did the latest merges, you might be able to help

I need to move on but I don't want to leave this PR hanging. Re-translating all strings to a dozen languages while we converge on the label naming is not the best time investment, so let's decide on something meaningful in English

@GaryGriffin
Copy link
Member

I suggest changing to Type of surname. Once changed I will merge and publish unless someone else has a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants