-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GedcomExtensions] Allow exporting only one type of surnames #634
base: maintenance/gramps52
Are you sure you want to change the base?
[GedcomExtensions] Allow exporting only one type of surnames #634
Conversation
TestingChunks of GEDCOM file, before the change and after the filtering by before
after
|
@@ -181,10 +204,19 @@ def get_option_box(self): | |||
self.process_patronymic_list.append_text(_("Add Patronymic name after Given name")) | |||
self.process_patronymic_list.append_text(_("Ignore Patronymic name")) | |||
|
|||
hbox2 = Gtk.Box(orientation=Gtk.Orientation.HORIZONTAL, spacing=10) | |||
label2 = Gtk.Label(label=_("Keep one type of surnames:")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reads better as Type of "surname" to use:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear what "to use" is in this case. It needs to be more descriptive.
Another option is "Include only this type of surname" to match the "Include..." pattern of other items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daleathan thank you for updating the docs! FYI I also have this change in works |
@GaryGriffin since you did the latest merges, you might be able to help I need to move on but I don't want to leave this PR hanging. Re-translating all strings to a dozen languages while we converge on the label naming is not the best time investment, so let's decide on something meaningful in English |
I suggest changing to Type of surname. Once changed I will merge and publish unless someone else has a comment. |
Bug: https://gramps-project.org/bugs/view.php?id=13575
In Gramps surnames can be tagged with "inherited", "taken", "patronymic" etc. That tagging is not supported by GEDCOM and is lost during the export. The surnames end up space separated and create confusion when imported to other services (e.g. Geni, FamilySearch, etc.)
Example:
Maria (given) Skłodowska (inherited surname) Curie (taken surname)
0 @I0003@ INDI 1 NAME Maria /Skłodowska Curie/ 2 TYPE birth 2 GIVN Maria 2 SURN Skłodowska, Curie
It's customary in gene research to only use "maiden" names and many services expect that. Thus Gramps needs an option to export only one type of surname, e.g.
inherited