Skip to content

chore!: Pin CI dependencies and require Node 22 #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spotandjake
Copy link
Member

This upgrades our ci setup to use setup-ocaml@v3, we also drop support for ocaml 1.12.1 as it's not supported by setup-ocaml anymore.

This was also fixed downstream on libbinaryen here so assuming that gets merged we can drop the steps setting the env variables after we get to libbinaryen v122.

Succesor to #201

@spotandjake spotandjake requested a review from ospencer March 25, 2025 22:18
@spotandjake spotandjake self-assigned this Mar 25, 2025
@ospencer ospencer force-pushed the spotandjake-dep-cygwin branch from 79a67ba to 9038b15 Compare March 28, 2025 19:34
chore: Upgrade setup-ocaml
chore!: Drop support for OCaml 4.12
@ospencer ospencer force-pushed the spotandjake-dep-cygwin branch from 7679cfe to e67499f Compare March 28, 2025 19:42
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phated Can you take a look at this too? I originally made most of the changes here and I think it'd be good to have another pair of eyes.

@ospencer ospencer requested a review from phated March 30, 2025 05:49
@ospencer ospencer changed the title chore: Pin CI dependencies and use setup-ocaml@v3 chore!: Pin CI dependencies and require Node 22 Mar 30, 2025
@ospencer
Copy link
Member

I'll add a note about the OCaml 4.12 support for the changelog when I merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants