exclude org.graalvm dependencies from the deployable war/jar #503
Conversation
exclude org.graalvm dependencies which are required by asset-pipeline-core for bootRun but are not required in the deployed war/jar
| // exclude org.graalvm dependencies which are required by asset-pipeline-core | ||
| // for bootRun but are not required in the deployed war/jar | ||
| tasks.named { it in ['bootWar', 'bootJar', 'war'] }.configureEach { | ||
| classpath = classpath.findAll { | ||
| !it.toString().contains('org.graalvm.') | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Should this block only be included on condition that the asset-pipeline-grails feature is active?
There was a problem hiding this comment.
Should we put this in the gradle plugin?
There was a problem hiding this comment.
Should we put this in the gradle plugin?
I also thought about that 😄
But, then we are hiding stuff that will be hard to understand/debug for the end user, if it becomes a problem.
Better to keep it in sight and remove it when we find a better solution.
Maybe include a link to the issue in the comment?
There was a problem hiding this comment.
We could always add a feature flag for opt out. Documentation for the gradle plugin is how we avoid hiding this functionality and it's probably important to keep the end app size small. I imagine this is one of those enhancements that can result in a significant cost savings for people that run in cloud environments. We know the dependencies are only required in dev/locally, so I would push for it to be in the gradle plugin and we can add documentation about it so its known.
There was a problem hiding this comment.
Yes, I agree, it would definitely be nicer to hide it in the Gradle Plugin 👍
There was a problem hiding this comment.
I agree on making it conditioned on the asset-pipeline-grails feature being active and will add a link to one of the tickets noting the file size difference.
add link to Github issue
exclude org.graalvm dependencies which are required by asset-pipeline-core for bootRun but are not required in the deployed war/jar