Project cleanup #992
Project cleanup #992
Conversation
Goal of cleanup was to use the `org.grails.grails-publish` plugin and use a more composition based build approach.
use GrailsStringUtils.trimToNull() instead of apache commons version
| @@ -26,20 +26,20 @@ class HibernateGrailsPlugin extends Plugin { | |||
|
|
|||
| public static final String DEFAULT_DATA_SOURCE_NAME = HibernateDatastoreSpringInitializer.DEFAULT_DATA_SOURCE_NAME | |||
|
|
|||
| def grailsVersion = '3.1.0 > *' | |||
| def grailsVersion = '7.0.0 > *' | |||
There was a problem hiding this comment.
Doesn't this need to be 7.0.0-SNAPSHOT?
There was a problem hiding this comment.
I don't think so. Is it enforced somewhere?
There was a problem hiding this comment.
We had several PRs to update '7.0.0 > *' to '7.0.0-SNAPSHOT > *' is the only reason I ask. I assumed it was enforced by this code https://github.com/grails/grails-core/blob/80792f89dc73f349f029c544786a7422f962859d/grails-core/src/main/groovy/grails/plugins/DefaultGrailsPluginManager.java#L398
There was a problem hiding this comment.
It can generate the following warning, but does not error. We have set some of these to 7.0.0 and some to 7.0.0-SNAPSHOT.
Plugin [myplugin:0.1.0-rc3] may not be compatible with this application as the application Grails version is less than the plugin requires. Plugin is compatible with Grails version 3.3.10 > * but app is 4.0.0
There was a problem hiding this comment.
There was a problem hiding this comment.
Does it even make sense to set a SNAPSHOT version here?
Goal of cleanup is to use the
org.grails.grails-publishplugin and use a more composition based build approach.