This repository was archived by the owner on Mar 13, 2025. It is now read-only.
fix grails/gorm-hibernate5#973 for grails-7 (9.0.x) #985
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a port of grails/grails-database-migration#164 fixing #973 for grails-7 (gorm-hibernate5
9.0.x
/ database-migration9.0.0-SNAPSHOT
).i created a sample app to reproduce the issue on grails-7 (blank start.grails.org grails-7.0.0-M1 app, locally built/published
org.grails.plugins:database-migration:9.0.0-SNAPSHOT
):zyro23/gorm-hibernate5-973@79475d0
prior to the changes, running
./grailsw dbm-gorm-diff --dataSource=second
errors with:for secondary dataSources, the sessionFactory lookup as well as the hibernateDatastore lookup are now made with the dataSource name without the
dataSource_
prefix.after applying the changes and re-building/-publishing locally the command succeeds:
additional notes regarding the sample app (id say these are separate issues):
liquibase-commercial
explicitly, i do not think it makes sense for grails-database-migration to pull it in vialiquibase-hibernate5
transitively?liquibase.version
to4.27.0
explicitly to prevent boot's blessed version (4.29.2
) from taking precedencethanks & regards.