Skip to content

grails5 upgrade - geb issue #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

grails5 upgrade - geb issue #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 42 additions & 37 deletions complete/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ buildscript {
}
dependencies {
classpath "org.grails:grails-gradle-plugin:$grailsVersion"
Copy link
Contributor

@sdelamo sdelamo Nov 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be decoupled from the grails version

classpath "org.grails.plugins:hibernate5:7.0.0"
classpath "org.grails.plugins:hibernate5:7.1.0"
classpath "com.bertramlabs.plugins:asset-pipeline-gradle:$assetPipelineVersion"
//tag::buildscriptwebdriverbinaries[]
classpath "gradle.plugin.com.github.erdi.webdriver-binaries:webdriver-binaries-gradle-plugin:2.1" // <1>
Copy link
Contributor

@sdelamo sdelamo Nov 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 2.4

Expand Down Expand Up @@ -40,51 +40,54 @@ configurations {

dependencies {
developmentOnly("org.springframework.boot:spring-boot-devtools")
compile "org.springframework.boot:spring-boot-starter-logging"
compile "org.springframework.boot:spring-boot-autoconfigure"
compile "org.grails:grails-core"
compile "org.springframework.boot:spring-boot-starter-actuator"
compile "org.springframework.boot:spring-boot-starter-tomcat"
compile "org.grails:grails-web-boot"
compile "org.grails:grails-logging"
compile "org.grails:grails-plugin-rest"
compile "org.grails:grails-plugin-databinding"
compile "org.grails:grails-plugin-i18n"
compile "org.grails:grails-plugin-services"
compile "org.grails:grails-plugin-url-mappings"
compile "org.grails:grails-plugin-interceptors"
compile "org.grails.plugins:cache"
compile "org.grails.plugins:async"
compile "org.grails.plugins:scaffolding"
compile "org.grails.plugins:events"
compile "org.grails.plugins:hibernate5"
compile "org.hibernate:hibernate-core:5.4.0.Final"
compile "org.grails.plugins:gsp"
implementation "org.springframework.boot:spring-boot-starter-logging"
implementation "org.springframework.boot:spring-boot-autoconfigure"
implementation "org.grails:grails-core"
implementation "org.springframework.boot:spring-boot-starter-actuator"
implementation "org.springframework.boot:spring-boot-starter-tomcat"
implementation "org.grails:grails-web-boot"
implementation "org.grails:grails-logging"
implementation "org.grails:grails-plugin-rest"
implementation "org.grails:grails-plugin-databinding"
implementation "org.grails:grails-plugin-i18n"
implementation "org.grails:grails-plugin-services"
implementation "org.grails:grails-plugin-url-mappings"
implementation "org.grails:grails-plugin-interceptors"
implementation "org.grails.plugins:cache"
implementation "org.grails.plugins:async"
implementation "org.grails.plugins:scaffolding"
implementation "org.grails.plugins:events"
implementation "org.grails.plugins:hibernate5"
implementation "org.hibernate:hibernate-core:5.5.7.Final"
implementation "org.grails.plugins:gsp"
console "org.grails:grails-console"
profile "org.grails.profiles:web"
runtime "org.glassfish.web:el-impl:2.1.2-b03"
runtime "com.h2database:h2"
runtime "org.apache.tomcat:tomcat-jdbc"
runtime "javax.xml.bind:jaxb-api:2.3.0"
runtime "com.bertramlabs.plugins:asset-pipeline-grails:$assetPipelineVersion"
testCompile "org.grails:grails-gorm-testing-support"
testCompile "org.mockito:mockito-core"
testCompile "org.grails:grails-web-testing-support"
runtimeOnly "org.glassfish.web:el-impl:2.1.2-b03"
runtimeOnly "com.h2database:h2"
runtimeOnly "org.apache.tomcat:tomcat-jdbc"
runtimeOnly "javax.xml.bind:jaxb-api:2.3.0"
runtimeOnly "com.bertramlabs.plugins:asset-pipeline-grails:$assetPipelineVersion"
testImplementation "org.grails:grails-gorm-testing-support"
testImplementation "org.mockito:mockito-core"
testImplementation "org.grails:grails-web-testing-support"
//tag::gebdependencies[]
testCompile "org.grails.plugins:geb" // <2>
testCompile "org.seleniumhq.selenium:htmlunit-driver:2.35.1"
testImplementation "org.grails.plugins:geb" // <2>
testImplementation "org.seleniumhq.selenium:htmlunit-driver:2.35.1"
testRuntime 'net.sourceforge.htmlunit:htmlunit:2.35.0'
testRuntime "org.seleniumhq.selenium:selenium-chrome-driver:$seleniumVersion" // <3>
testRuntime "org.seleniumhq.selenium:selenium-firefox-driver:$seleniumVersion" // <4>
testCompile "org.seleniumhq.selenium:selenium-remote-driver:$seleniumVersion" // <5>
testCompile "org.seleniumhq.selenium:selenium-api:$seleniumVersion" // <5>
testCompile "org.seleniumhq.selenium:selenium-support:$seleniumVersion" // <5>
testRuntimeOnly "org.seleniumhq.selenium:selenium-chrome-driver:$seleniumVersion" // <3>
testRuntimeOnly "org.seleniumhq.selenium:selenium-firefox-driver:$seleniumVersion" // <4>
testImplementation "org.seleniumhq.selenium:selenium-remote-driver:$seleniumVersion" // <5>
testImplementation "org.seleniumhq.selenium:selenium-api:$seleniumVersion" // <5>
testImplementation "org.seleniumhq.selenium:selenium-support:$seleniumVersion" // <5>
//end::gebdependencies[]
}

//tag::webdriverBinaries[]
webdriverBinaries {
chromedriver "${chromeDriverVersion}" // <6>
chromedriver {
Copy link
Contributor

@sdelamo sdelamo Nov 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should use the same version as grails_i18n guide

version = "${chromeDriverVersion}" // <6>
architecture ="X86"
}
geckodriver "${geckodriverVersion}" // <7>
Copy link
Contributor

@sdelamo sdelamo Nov 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should use the same version as grails_i18n guide

}
//end::webdriverBinaries[]
Expand Down Expand Up @@ -116,3 +119,5 @@ assets {
minifyJs = true
minifyCss = true
}

tasks.withType(Test) { useJUnitPlatform() }
12 changes: 8 additions & 4 deletions complete/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
grailsVersion=4.0.1
gormVersion=7.0.2.RELEASE
assetPipelineVersion=3.0.11
grailsVersion=5.0.0
Copy link
Contributor

@sdelamo sdelamo Nov 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.0.1

gormVersion=7.1.0.M5
Copy link
Contributor

@sdelamo sdelamo Nov 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.1.0

groovyVersion=3.0.7
org.gradle.daemon=true
org.gradle.parallel=true
org.gradle.jvmargs=-Dfile.encoding=UTF-8 -Xmx1024M
assetPipelineVersion=3.3.4
webdriverBinariesVersion=1.4
Copy link
Contributor

@sdelamo sdelamo Nov 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 2.4

seleniumVersion=3.141.59
chromeDriverVersion=78.0.3904.105
Copy link
Contributor

@sdelamo sdelamo Nov 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be the same as grails_i18n guide

geckodriverVersion=0.26.0
geckodriverVersion=0.26.0
Copy link
Contributor

@sdelamo sdelamo Nov 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be the same as grails_i18n guide

Binary file modified complete/gradle/wrapper/gradle-wrapper.jar
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion complete/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.4-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-6.9-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Loading