-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #9511 #9566
Merged
Merged
Revert #9511 #9566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts #9511 as it panics ingesters. The details are: ``` │ panic: runtime error: invalid memory address or nil pointer dereference │ │ panic: runtime error: invalid memory address or nil pointer dereference │ │ [signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x13b2350] │ $GOROOT/src/runtime/panic.go:785 +0x124 │ │ github.com/twmb/franz-go/pkg/kgo/internal/pool.(*BucketedPool[...]).Get(0x0?, 0x0?) ``` Signed-off-by: gotjosh <[email protected]>
pracucci
approved these changes
Oct 8, 2024
ortuman
approved these changes
Oct 8, 2024
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-9566-to-r311 origin/r311
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x ab3e627b1da134f33c06dd09ee4402a2eaad68f1
# Push it to GitHub
git push --set-upstream origin backport-9566-to-r311
git switch main
# Remove the local backport branch
git branch -D backport-9566-to-r311 Then, create a pull request where the |
gotjosh
added a commit
that referenced
this pull request
Oct 8, 2024
This reverts #9511 as it panics ingesters. The details are: ``` │ panic: runtime error: invalid memory address or nil pointer dereference │ │ panic: runtime error: invalid memory address or nil pointer dereference │ │ [signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x13b2350] │ $GOROOT/src/runtime/panic.go:785 +0x124 │ │ github.com/twmb/franz-go/pkg/kgo/internal/pool.(*BucketedPool[...]).Get(0x0?, 0x0?) ``` Signed-off-by: gotjosh <[email protected]> (cherry picked from commit ab3e627)
Merged
gotjosh
added a commit
that referenced
this pull request
Oct 8, 2024
This reverts #9511 as it panics ingesters. The details are: ``` │ panic: runtime error: invalid memory address or nil pointer dereference │ │ panic: runtime error: invalid memory address or nil pointer dereference │ │ [signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x13b2350] │ $GOROOT/src/runtime/panic.go:785 +0x124 │ │ github.com/twmb/franz-go/pkg/kgo/internal/pool.(*BucketedPool[...]).Get(0x0?, 0x0?) ``` Signed-off-by: gotjosh <[email protected]> (cherry picked from commit ab3e627)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #9511 as it panics ingesters.
The details are: