Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of leaf-node round-robin algorithm #9340

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chencs
Copy link
Contributor

@chencs chencs commented Sep 19, 2024

What this PR does

At a leaf node, QueuingAlgorithm isn't used; we simply dequeue from the Node's localQueue. To avoid confusion, we will use a nil QueuingAlgorithm in these cases, and append nil to the list of queuing algorithms at tree creation, so the leaf node behavior is always accounted for.

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@chencs chencs force-pushed the casie/remove-round-robin-use branch 2 times, most recently from 6bfb6b6 to fb668d5 Compare September 19, 2024 22:49
@chencs chencs marked this pull request as ready for review September 19, 2024 23:19
@chencs chencs requested a review from a team as a code owner September 19, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant